Remove code which CHECKs for a valid extension ID in

Remove code which CHECKs for a valid extension ID in
ExtensionDispatcher::AllowScriptInjection. It's causing renderer crashes.


BUG=none
TEST=none

[Aaron Boodman, 2012-03-16 03:48:25]

http://codereview.chromium.org/9699049/diff/1/chrome/renderer/extensions/exte...
File chrome/renderer/extensions/extension_dispatcher.cc (left):

http://codereview.chromium.org/9699049/diff/1/chrome/renderer/extensions/exte...
chrome/renderer/extensions/extension_dispatcher.cc:340: CHECK_EQ("invalid",
extension_id);
Can you LOG(ERROR) the details? This seems weird, like there is probably some
other bug. We should at least capture the info.

Maybe also put a histogram in so we can see how often it happens.

[not at google - send to devlin, 2012-03-16 04:54:45]

Submitting this before the deathly slowness of rietveld sends me to sleep.

http://codereview.chromium.org/9699049/diff/1/chrome/renderer/extensions/exte...
File chrome/renderer/extensions/extension_dispatcher.cc (left):

http://codereview.chromium.org/9699049/diff/1/chrome/renderer/extensions/exte...
chrome/renderer/extensions/extension_dispatcher.cc:340: CHECK_EQ("invalid",
extension_id);
On 2012/03/16 03:48:28, Aaron Boodman wrote:
> Can you LOG(ERROR) the details? This seems weird, like there is probably some
> other bug. We should at least capture the info.
> 
> Maybe also put a histogram in so we can see how often it happens.

Done.

[commit-bot: I haz the power, 2012-03-16 04:55:07]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[not at google - send to devlin, 2012-03-16 04:55:52]

oh, not lgtm. i'm tireder than I thought.

[not at google - send to devlin, 2012-03-16 06:07:09]

On 2012/03/16 06:03:59, Aaron Boodman wrote:

good point

[Aaron Boodman, 2012-03-16 07:24:09]

I'm a man of few words.

LGTM

[commit-bot: I haz the power, 2012-03-16 07:37:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/9699049/6001

[commit-bot: I haz the power, 2012-03-16 07:37:43]

Can't apply patch for file chrome/renderer/extensions/extension_dispatcher.cc.
While running patch -p1 --forward --force;
patching file chrome/renderer/extensions/extension_dispatcher.cc
Hunk #1 FAILED at 329.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/renderer/extensions/extension_dispatcher.cc.rej

[not at google - send to devlin, 2012-03-21 06:05:52]

This got incorporated into http://crrev.com/127899 so closing.