Remove code which CHECKs for a valid extension ID in

chrome/renderer/extensions/extension_dispatcher.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/extension_dispatcher.h"
 
 #include "base/command_line.h"
 #include "chrome/common/child_process_logging.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/extensions/extension.h"
@@ skipping 310 matching lines @@
   if (context_type == ChromeV8Context::CONTENT_SCRIPT ||
       extensions_.ExtensionBindingsAllowed(ExtensionURLInfo(
           frame->document().securityOrigin(),
           UserScriptSlave::GetDataSourceURLForFrame(frame)))) {
     // If the extension is a custom API binding, only allow if the extension
     // has permission to use the API.
     std::string custom_binding_api_name = util::GetAPIName(v8_extension_name);
     if (!custom_binding_api_name.empty()) {
       std::string extension_id = GetExtensionID(frame, world_id);
       const Extension* extension = extensions_.GetByID(extension_id);
-      if (!extension) {
-        // This can happen when a resource is blocked due to CSP; a valid
-        // chrome-extension:// URL is navigated to, so it passes the initial
-        // checks, but the URL gets changed to "chrome-extension://invalid"
-        // afterwards (see chrome_content_renderer_client.cc). An extension
-        // page still gets loaded, just for the extension with ID "invalid",
-        // which of course isn't found so GetById extension will be NULL.
-        //
-        // Reference: http://crbug.com/111614.
-        CHECK_EQ("invalid", extension_id);

[Aaron Boodman, 2012/03/16 03:48:28]

Can you LOG(ERROR) the details? This seems weird, like there is probably some
other bug. We should at least capture the info.

Maybe also put a histogram in so we can see how often it happens.

[not at google - send to devlin, 2012/03/16 04:54:46]

Done.

+      if (!extension)
         return false;
-      }
       return util::AllowAPIInjection(custom_binding_api_name, *extension, this);
     }
 
     return true;
   }
 
   return false;
 }
 
 void ExtensionDispatcher::DidCreateScriptContext(
@@ skipping 188 matching lines @@
   webrequest_adblock_ = adblock;
   webrequest_adblock_plus_ = adblock_plus;
   webrequest_other_ = other;
 }
 
 void ExtensionDispatcher::OnShouldClose(const std::string& extension_id,
                                         int sequence_id) {
   RenderThread::Get()->Send(
       new ExtensionHostMsg_ShouldCloseAck(extension_id, sequence_id));
 }