Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 9696008: TestScreen shouldn't be marked aura export (Closed)

Created:
8 years, 9 months ago by Elliot Glaysher
Modified:
8 years, 9 months ago
CC:
chromium-reviews, jam, sadrul, hashimoto+watch_chromium.org, ben+watch_chromium.org, aboxhall+watch_chromium.org, dhollowa+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, tfarina, ctguil+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

Recommit r125950, which was reverted by r125958 due to link failures on win_aura bot. Aura/Ash split: Move ScreenAura to aura::RootWindowScreen. What is now aura::RootWindowScreen was tightly bundled with aura::RootWindow. Instead of moving it to ash::ScreenAsh, I renamed it aurea::RootWindowScreen because there's a bunch of unit tests that use RootWindow as if it were the desktop. Screen integration stuff has been moved out of RootWindow (and related observers) and into ash::Shell. BUG=116458 First Review URL: http://codereview.chromium.org/9616045 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126464

Patch Set 1 #

Patch Set 2 : Rebase on ToT, and hopefully fix conflict's with joi's patch #

Patch Set 3 : (same patch; reuploading for try bot revision) #

Patch Set 4 : Another rebase #

Patch Set 5 : Rebase again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -311 lines) Patch
M ash/ash.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + ash/screen_ash.h View 2 chunks +14 lines, -12 lines 0 comments Download
A + ash/screen_ash.cc View 1 chunk +16 lines, -15 lines 0 comments Download
M ash/shell.h View 6 chunks +16 lines, -0 lines 0 comments Download
M ash/shell.cc View 4 chunks +19 lines, -0 lines 0 comments Download
A ash/shell_observer.h View 1 chunk +24 lines, -0 lines 0 comments Download
M ash/wm/base_layout_manager.h View 3 chunks +4 lines, -0 lines 0 comments Download
M ash/wm/base_layout_manager.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M ash/wm/base_layout_manager_unittest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/shelf_layout_manager.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/shelf_layout_manager_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/toplevel_layout_manager_unittest.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M ash/wm/workspace/workspace_event_filter.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_manager.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_manager_unittest.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/accessibility_event_router_views_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M content/test/test_renderer_host.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M ui/aura/aura.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/root_window.h View 4 chunks +0 lines, -7 lines 0 comments Download
M ui/aura/root_window.cc View 4 chunks +0 lines, -11 lines 0 comments Download
M ui/aura/root_window_observer.h View 1 chunk +0 lines, -3 lines 0 comments Download
D ui/aura/screen_aura.h View 1 chunk +0 lines, -60 lines 0 comments Download
D ui/aura/screen_aura.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M ui/aura/test/aura_test_base.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A + ui/aura/test/test_screen.h View 2 chunks +10 lines, -22 lines 0 comments Download
A ui/aura/test/test_screen.cc View 1 chunk +61 lines, -0 lines 0 comments Download
M ui/gfx/screen.h View 2 chunks +2 lines, -2 lines 0 comments Download
A + ui/gfx/screen_ash.cc View 2 chunks +3 lines, -4 lines 0 comments Download
D ui/gfx/screen_aura.cc View 1 chunk +0 lines, -80 lines 0 comments Download
M ui/ui.gyp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/views/test/views_test_base.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Elliot Glaysher
The only difference is the removal of AURA_EXPORT in TestScreen. Also, win_aura trybot has gone ...
8 years, 9 months ago (2012-03-12 22:29:57 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 9 months ago (2012-03-12 22:37:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/9696008/1
8 years, 9 months ago (2012-03-12 22:42:12 UTC) #3
commit-bot: I haz the power
Can't apply patch for file content/browser/renderer_host/test_render_view_host.cc. While running patch -p1 --forward --force; patching file content/browser/renderer_host/test_render_view_host.cc ...
8 years, 9 months ago (2012-03-12 22:42:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/9696008/3006
8 years, 9 months ago (2012-03-13 00:37:50 UTC) #5
commit-bot: I haz the power
Can't apply patch for file ui/ui.gyp. While running patch -p1 --forward --force; patching file ui/ui.gyp ...
8 years, 9 months ago (2012-03-13 02:38:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/9696008/1039
8 years, 9 months ago (2012-03-13 03:08:21 UTC) #7
commit-bot: I haz the power
Can't apply patch for file ash/wm/workspace/workspace_window_resizer_unittest.cc. While running patch -p1 --forward --force; patching file ash/wm/workspace/workspace_window_resizer_unittest.cc ...
8 years, 9 months ago (2012-03-13 05:37:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/9696008/41
8 years, 9 months ago (2012-03-13 18:25:08 UTC) #9
commit-bot: I haz the power
8 years, 9 months ago (2012-03-13 21:09:22 UTC) #10
Change committed as 126464

Powered by Google App Engine
This is Rietveld 408576698