Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 9616045: Aura/Ash split: Move ScreenAura to ash::ScreenAsh. (Closed)

Created:
8 years, 9 months ago by Elliot Glaysher
Modified:
8 years, 9 months ago
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Aura/Ash split: Move ScreenAura to aura::RootWindowScreen. What is now aura::RootWindowScreen was tightly bundled with aura::RootWindow. Instead of moving it to ash::ScreenAsh, I renamed it aurea::RootWindowScreen because there's a bunch of unit tests that use RootWindow as if it were the desktop. Screen integration stuff has been moved out of RootWindow (and related observers) and into ash::Shell. BUG=116458 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125950

Patch Set 1 #

Patch Set 2 : Fix typos in unit tests. #

Patch Set 3 : Maybe this will fix them. #

Patch Set 4 : Rebase to ToT so I can fix tests that were added since I started writing. #

Patch Set 5 : Fix more unit tests that didn't exist. #

Patch Set 6 : Move it back to aura::RootWindowScreen and add screens everywhere. #

Patch Set 7 : Maybe fix aura_shell_unittests #

Patch Set 8 : Use a separate aura::TestScreen in tests instead, partially reverting to patchset 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -306 lines) Patch
M ash/ash.gyp View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
A + ash/screen_ash.h View 1 2 3 4 5 6 7 2 chunks +13 lines, -11 lines 0 comments Download
A + ash/screen_ash.cc View 6 7 1 chunk +16 lines, -15 lines 0 comments Download
M ash/shell.h View 1 2 3 4 5 6 7 6 chunks +16 lines, -0 lines 0 comments Download
M ash/shell.cc View 1 2 3 4 5 6 7 4 chunks +19 lines, -0 lines 0 comments Download
A ash/shell_observer.h View 1 chunk +24 lines, -0 lines 0 comments Download
M ash/wm/base_layout_manager.h View 1 2 3 4 5 6 7 3 chunks +4 lines, -0 lines 0 comments Download
M ash/wm/base_layout_manager.cc View 1 2 3 3 chunks +5 lines, -0 lines 0 comments Download
M ash/wm/base_layout_manager_unittest.cc View 1 6 7 3 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/shelf_layout_manager.cc View 1 2 3 6 7 4 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/shelf_layout_manager_unittest.cc View 1 2 3 4 6 7 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/toplevel_layout_manager_unittest.cc View 1 6 7 4 chunks +4 lines, -6 lines 0 comments Download
M ash/wm/workspace/workspace_event_filter.cc View 1 2 3 4 5 6 7 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager.cc View 1 2 3 4 5 6 7 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_manager.cc View 1 2 3 4 5 6 7 3 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_manager_unittest.cc View 1 2 3 4 5 6 7 4 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 2 3 6 7 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/accessibility_event_router_views_unittest.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/test_render_view_host.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M ui/aura/aura.gyp View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/root_window.h View 1 2 3 4 chunks +0 lines, -7 lines 0 comments Download
M ui/aura/root_window.cc View 1 2 3 4 chunks +0 lines, -11 lines 0 comments Download
M ui/aura/root_window_observer.h View 1 chunk +0 lines, -3 lines 0 comments Download
D ui/aura/screen_aura.h View 1 chunk +0 lines, -60 lines 0 comments Download
D ui/aura/screen_aura.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M ui/aura/test/aura_test_base.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
A + ui/aura/test/test_screen.h View 1 2 3 4 5 6 7 3 chunks +9 lines, -20 lines 0 comments Download
A ui/aura/test/test_screen.cc View 1 2 3 4 5 6 7 1 chunk +61 lines, -0 lines 0 comments Download
M ui/gfx/screen.h View 1 chunk +1 line, -1 line 0 comments Download
A + ui/gfx/screen_ash.cc View 1 chunk +2 lines, -3 lines 0 comments Download
D ui/gfx/screen_aura.cc View 1 chunk +0 lines, -80 lines 0 comments Download
M ui/ui.gyp View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M ui/views/test/views_test_base.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura_unittest.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Elliot Glaysher
8 years, 9 months ago (2012-03-08 01:17:21 UTC) #1
Elliot Glaysher
ptal. Something will have to be done about the ui side of Screen, but not ...
8 years, 9 months ago (2012-03-09 00:09:19 UTC) #2
Ben Goodger (Google)
lgtm
8 years, 9 months ago (2012-03-09 21:06:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/9616045/20001
8 years, 9 months ago (2012-03-09 21:13:49 UTC) #4
commit-bot: I haz the power
Try job failure for 9616045-20001 (retry) on linux_clang for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-09 21:54:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/9616045/20001
8 years, 9 months ago (2012-03-09 22:05:11 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-10 00:18:51 UTC) #7
Change committed as 125950

Powered by Google App Engine
This is Rietveld 408576698