Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 9691067: Add a new 'run_all_unittests' target in base (Closed)

Created:
8 years, 9 months ago by akalin
Modified:
8 years, 9 months ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Add a new 'run_all_unittests' target in base Make all the places that include run_all_unittests.cc manually depend on this target instead. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127911

Patch Set 1 #

Total comments: 8

Patch Set 2 : Address comments #

Total comments: 2

Patch Set 3 : Add back needed deps on test_support_base #

Patch Set 4 : Sync to head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -26 lines) Patch
M base/base.gyp View 1 2 chunks +13 lines, -3 lines 0 comments Download
M build/temp_gyp/googleurl.gyp View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 chunks +3 lines, -3 lines 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/virtual_driver_port_monitor.gyp View 1 chunk +1 line, -3 lines 0 comments Download
M dbus/dbus.gyp View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M sync/sync.gyp View 1 2 1 chunk +1 line, -7 lines 0 comments Download
M third_party/cacheinvalidation/cacheinvalidation.gyp View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/libphonenumber/libphonenumber.gyp View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
akalin
+rsleevi for review
8 years, 9 months ago (2012-03-16 02:07:58 UTC) #1
Ryan Sleevi
Not a base/ OWNER, but some GYP-y feedback. Most of the changes look good, but ...
8 years, 9 months ago (2012-03-16 02:45:25 UTC) #2
Ryan Sleevi
This is what I get for only taking two passes through: http://codereview.chromium.org/9691067/diff/1/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (left): ...
8 years, 9 months ago (2012-03-16 02:48:45 UTC) #3
akalin
PTAL http://codereview.chromium.org/9691067/diff/1/base/base.gyp File base/base.gyp (right): http://codereview.chromium.org/9691067/diff/1/base/base.gyp#newcode149 base/base.gyp:149: 'test_support_base', On 2012/03/16 02:45:25, Ryan Sleevi wrote: > ...
8 years, 9 months ago (2012-03-16 06:59:20 UTC) #4
Ryan Sleevi
This looks right and good to me. You'll want to get a base/ OWNERS to ...
8 years, 9 months ago (2012-03-16 17:27:30 UTC) #5
akalin
+brettw for review http://codereview.chromium.org/9691067/diff/7001/sync/sync.gyp File sync/sync.gyp (left): http://codereview.chromium.org/9691067/diff/7001/sync/sync.gyp#oldcode253 sync/sync.gyp:253: '../base/base.gyp:test_support_base', On 2012/03/16 17:27:30, Ryan Sleevi ...
8 years, 9 months ago (2012-03-16 18:53:50 UTC) #6
brettw
lgtm
8 years, 9 months ago (2012-03-16 22:46:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/9691067/13002
8 years, 9 months ago (2012-03-16 22:52:44 UTC) #8
commit-bot: I haz the power
Presubmit check for 9691067-13002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 9 months ago (2012-03-16 22:52:48 UTC) #9
akalin
+satorux for dbus/ +scottbyer for cloud_print/ rsleevi@, do I have a LGTM from you? (you ...
8 years, 9 months ago (2012-03-21 00:11:21 UTC) #10
Ryan Sleevi
On 2012/03/21 00:11:21, akalin wrote: > +satorux for dbus/ > +scottbyer for cloud_print/ > > ...
8 years, 9 months ago (2012-03-21 00:12:28 UTC) #11
Scott Byer
lgtm
8 years, 9 months ago (2012-03-21 00:44:55 UTC) #12
satorux1
LGTM. thank you for the cleanup
8 years, 9 months ago (2012-03-21 04:51:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/9691067/18001
8 years, 9 months ago (2012-03-21 04:56:39 UTC) #14
commit-bot: I haz the power
8 years, 9 months ago (2012-03-21 05:55:08 UTC) #15
Change committed as 127911

Powered by Google App Engine
This is Rietveld 408576698