Add a new 'run_all_unittests' target in base

sync/sync.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
   },
   'targets': [
     # The core sync library.
@@ skipping 232 matching lines @@
     # library because the unit test files have to be compiled directly
     # into the executable, so we push the target files to the
     # depending executable target via direct_dependent_settings.
     {
       'target_name': 'sync_tests',
       'type': 'none',
       # We only want unit test executables to include this target.
       'suppress_wildcard': 1,
       'dependencies': [
         '../base/base.gyp:base',
-        '../base/base.gyp:test_support_base',

[Ryan Sleevi, 2012/03/16 17:27:30]

Is this target really not needed anymore?

I'm assuming you're relying on the fact that targets which depend on this will
'probably' include ../base/base.gyp:run_all_unittests and pick up the
dependency?

Might want to double check the code within the 'sources' here to make sure it
doesn't really depend on test_support_base - otherwise/if that's too much work,
I'd suggest leaving this dependency here

Removing 261 is fine

[akalin, 2012/03/16 18:53:50]

Good point.  I audited all the targets and added back in the dep on
test_support_base when they actually do directly depend on it (usually
test_timeouts)

         '../testing/gmock.gyp:gmock',
         '../testing/gtest.gyp:gtest',
         'sync',
         'test_support_sync',
       ],
       'export_dependent_settings': [
         '../base/base.gyp:base',
-        '../base/base.gyp:test_support_base',
         '../testing/gmock.gyp:gmock',
         '../testing/gtest.gyp:gtest',
         'sync',
         'test_support_sync',
       ],
       'direct_dependent_settings': {
         'variables': { 'enable_wexit_time_destructors': 1, },
         'include_dirs': [
           '..',
         ],
@@ skipping 45 matching lines @@
     },
 
     # The unit test executable for sync tests.  Currently this isn't
     # automatically run, as there is already a sync_unit_tests
     # executable in chrome.gyp; this is just to make sure that all the
     # link-time dependencies for the files in the targets above
     # resolve.
     #
     # TODO(akalin): Rename this to sync_unit_tests once we've moved
     # everything from chrome.gyp.
-    #
-    # TODO(akalin): Make base.gyp have a test_main target that
-    # includes run_all_unittests.cc and the possible tcmalloc
-    # dependency and use that everywhere.
     {
       'target_name': 'sync_unit_tests_canary',
       'type': 'executable',
-      'sources': [
-        '../base/test/run_all_unittests.cc',
-      ],
       'dependencies': [
+        '../base/base.gyp:run_all_unittests',
         'sync_tests',
       ],
 
       # TODO(akalin): This is needed because histogram.cc uses
       # leak_annotations.h, which pulls this in.  Make 'base'
       # propagate this dependency.
       'conditions': [
         ['OS=="linux" and linux_use_tcmalloc==1', {
           'dependencies': [
             '../base/allocator/allocator.gyp:allocator',
           ],
         }],
       ],
     },
   ],
 }