Add a new 'run_all_unittests' target in base

chrome/chrome_tests.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 {
   'variables' : {
     'pyautolib_sources': [
       'app/chrome_command_ids.h',
       'app/chrome_dll_resource.h',
       'common/automation_constants.h',
       'common/pref_names.cc',
@@ skipping 310 matching lines @@
     },
     {
       'target_name': 'test_support_ui',
       'type': 'static_library',
       'dependencies': [
         'chrome_resources.gyp:chrome_resources',
         'chrome_resources.gyp:chrome_strings',
         'chrome_resources.gyp:theme_resources',
         'test_support_common',
         '../skia/skia.gyp:skia',
+        '../base/base.gyp:run_all_unittests',
         '../testing/gtest.gyp:gtest',
       ],
       'export_dependent_settings': [
         'test_support_common',
+        '../base/base.gyp:run_all_unittests',

[Ryan Sleevi, 2012/03/16 02:45:25]

And the motivation for this (and on 443)

[akalin, 2012/03/16 06:59:20]

rendered moot.

       ],
       'include_dirs': [
         '..',
       ],
       'sources': [
         'test/automation/proxy_launcher.cc',
         'test/automation/proxy_launcher.h',
         'test/base/layout_test_http_server.cc',
         'test/base/layout_test_http_server.h',
         'test/reliability/automated_ui_test_base.cc',
         'test/reliability/automated_ui_test_base.h',
         'test/ui/javascript_test_util.cc',
         'test/ui/npapi_test_helper.cc',
         'test/ui/npapi_test_helper.h',
-        'test/ui/run_all_unittests.cc',

[Ryan Sleevi, 2012/03/16 02:48:45]

This is a different test harness.

[akalin, 2012/03/16 06:59:20]

Indeed!  reverted.

         'test/ui/ui_layout_test.cc',
         'test/ui/ui_layout_test.h',
         'test/ui/ui_perf_test.cc',
         'test/ui/ui_perf_test.h',
         'test/ui/ui_test.cc',
         'test/ui/ui_test.h',
         'test/ui/ui_test_suite.cc',
         'test/ui/ui_test_suite.h',
       ],
       'conditions': [
@@ skipping 67 matching lines @@
         'browser/sync/notifier/mock_sync_notifier_observer.h',
       ],
     },
     {
       'target_name': 'test_support_unit',
       'type': 'static_library',
       'dependencies': [
         'chrome_resources.gyp:chrome_resources',
         'chrome_resources.gyp:chrome_strings',
         'test_support_common',
+        '../base/base.gyp:run_all_unittests',
         '../skia/skia.gyp:skia',
         '../testing/gtest.gyp:gtest',
       ],
+      'export_dependent_settings': [
+        '../base/base.gyp:run_all_unittests',
+      ],
       'include_dirs': [
         '..',
       ],
-      'sources': [
-        'test/base/run_all_unittests.cc',

[Ryan Sleevi, 2012/03/16 02:48:45]

As is this

[akalin, 2012/03/16 06:59:20]

Reverted this too.

-      ],
-      'conditions': [
-        ['toolkit_uses_gtk == 1', {
-          'dependencies': [
-            # Needed for the following #include chain:
-            #   test/base/run_all_unittests.cc
-            #   test/base/chrome_test_suite.h
-            #   gtk/gtk.h
-            '../build/linux/system.gyp:gtk',
-          ],
-        }],
-      ],
     },
     {
       'target_name': 'automated_ui_tests',
       'type': 'executable',
       'dependencies': [
         'browser',
         'chrome_resources.gyp:theme_resources',
         'renderer',
         'test_support_common',
         'test_support_ui',
@@ skipping 651 matching lines @@
             },
           },
         }],
       ]
     },
     {
       'target_name': 'chromedriver_unittests',
       'type': 'executable',
       'dependencies': [
         'chromedriver_lib',
-        '../base/base.gyp:test_support_base',
+        '../base/base.gyp:run_all_unittests',
         '../testing/gtest.gyp:gtest',
         '../skia/skia.gyp:skia',
       ],
       'include_dirs': [
         '..',
       ],
       'sources': [
-        '../base/test/run_all_unittests.cc',
         'test/webdriver/commands/set_timeout_commands_unittest.cc',
         'test/webdriver/frame_path_unittest.cc',
         'test/webdriver/http_response_unittest.cc',
         'test/webdriver/keycode_text_conversion_unittest.cc',
         'test/webdriver/webdriver_capabilities_parser_unittest.cc',
         'test/webdriver/webdriver_dispatch_unittest.cc',
         'test/webdriver/webdriver_key_converter_unittest.cc',
         'test/webdriver/webdriver_test_util.cc',
         'test/webdriver/webdriver_test_util.h',
         'test/webdriver/webdriver_util_unittest.cc',
@@ skipping 2465 matching lines @@
           'dependencies': [
             '../ui/views/views.gyp:views',
           ],
         }],
       ],
     },
     {
       'target_name': 'sync_unit_tests',
       'type': 'executable',
       'sources': [
-        '../base/test/run_all_unittests.cc',
         'browser/sync/api/sync_change_unittest.cc',
         'browser/sync/api/sync_error_unittest.cc',
         'browser/sync/internal_api/change_record_unittest.cc',
         'browser/sync/internal_api/debug_info_event_listener_unittest.cc',
         'browser/sync/internal_api/syncapi_server_connection_manager_unittest.cc',
         'browser/sync/internal_api/syncapi_unittest.cc',
         'browser/sync/internal_api/js_mutation_event_observer_unittest.cc',
         'browser/sync/internal_api/js_sync_manager_observer_unittest.cc',
         'browser/sync/notifier/cache_invalidation_packet_handler_unittest.cc',
         'browser/sync/notifier/chrome_invalidation_client_unittest.cc',
         'browser/sync/notifier/chrome_system_resources_unittest.cc',
         'browser/sync/notifier/invalidation_notifier_unittest.cc',
         'browser/sync/notifier/non_blocking_invalidation_notifier_unittest.cc',
         'browser/sync/notifier/p2p_notifier_unittest.cc',
         'browser/sync/notifier/registration_manager_unittest.cc',
         'browser/sync/notifier/sync_notifier_factory_unittest.cc',
       ],
       'include_dirs': [
         '..',
       ],
       'dependencies': [
         '../sync/sync.gyp:sync_tests',
-        '../base/base.gyp:test_support_base',
+        '../base/base.gyp:run_all_unittests',
         '../jingle/jingle.gyp:notifier_test_util',
         '../net/net.gyp:net',
         '../net/net.gyp:net_test_support',
         '../testing/gmock.gyp:gmock',
         '../testing/gtest.gyp:gtest',
         'syncapi_core',
         'sync_notifier',
         'test_support_syncapi',
         'test_support_syncapi_service',
         'test_support_sync_notifier',
@@ skipping 927 matching lines @@
               # Use outputs of this action as inputs for the main target build.
               # Seems as a misnomer but makes this happy on Linux (scons).
               'process_outputs_as_sources': 1,
             },
           ],  # 'actions'
         },
       ]
     }],  # 'coverage!=0'
   ],  # 'conditions'
 }