Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Side by Side Diff: chrome/browser/resources/options2/cookies_list.js

Issue 9665012: Possible JavaScript errors caught by the closure compiler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options', function() { 5 cr.define('options', function() {
6 const DeletableItemList = options.DeletableItemList; 6 const DeletableItemList = options.DeletableItemList;
7 const DeletableItem = options.DeletableItem; 7 const DeletableItem = options.DeletableItem;
8 const ArrayDataModel = cr.ui.ArrayDataModel; 8 const ArrayDataModel = cr.ui.ArrayDataModel;
9 const ListSingleSelectionModel = cr.ui.ListSingleSelectionModel; 9 const ListSingleSelectionModel = cr.ui.ListSingleSelectionModel;
10 10
(...skipping 516 matching lines...) Expand 10 before | Expand all | Expand 10 after
527 while (element.childNodes.length > 1) 527 while (element.childNodes.length > 1)
528 element.removeChild(element.firstChild); 528 element.removeChild(element.firstChild);
529 if (table) 529 if (table)
530 element.insertBefore(table, element.firstChild); 530 element.insertBefore(table, element.firstChild);
531 }, 531 },
532 532
533 /** 533 /**
534 * The parent of this cookie tree node. 534 * The parent of this cookie tree node.
535 * @type {?CookieTreeNode|CookieListItem} 535 * @type {?CookieTreeNode|CookieListItem}
536 */ 536 */
537 get parent(parent) { 537 get parent() {
Tyler Breisacher (Chromium) 2012/03/09 22:36:17 I assume the parameter is just ignored, so I don't
arv (Not doing code reviews) 2012/03/10 00:18:54 This is a V8 bug. It is illegal to have paramaters
538 // See below for an explanation of this special case. 538 // See below for an explanation of this special case.
539 if (typeof this.parent_ == 'number') 539 if (typeof this.parent_ == 'number')
540 return this.list_.getListItemByIndex(this.parent_); 540 return this.list_.getListItemByIndex(this.parent_);
541 return this.parent_; 541 return this.parent_;
542 }, 542 },
543 set parent(parent) { 543 set parent(parent) {
544 if (parent == this.parent) 544 if (parent == this.parent)
545 return; 545 return;
546 if (parent instanceof CookieListItem) { 546 if (parent instanceof CookieListItem) {
547 // If the parent is to be a CookieListItem, then we keep the reference 547 // If the parent is to be a CookieListItem, then we keep the reference
(...skipping 298 matching lines...) Expand 10 before | Expand all | Expand 10 after
846 parent.clear(); 846 parent.clear();
847 this.addByParent_(parent, 0, children); 847 this.addByParent_(parent, 0, children);
848 parent.endBatchUpdates(); 848 parent.endBatchUpdates();
849 }, 849 },
850 }; 850 };
851 851
852 return { 852 return {
853 CookiesList: CookiesList 853 CookiesList: CookiesList
854 }; 854 };
855 }); 855 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698