Issue 9665012: Possible JavaScript errors caught by the closure compiler

Issue 9665012: Possible JavaScript errors caught by the closure compiler (Closed)

Created:
8 years, 9 months ago by Tyler Breisacher (Chromium)

Modified:
8 years, 9 months ago

Reviewers:
csilv, arv (Not doing code reviews)

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Possible JavaScript errors caught by the closure compiler BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125964

Patch Set 1 #

Total comments: 3

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/resources/options2/cookies_list.js	View		1 chunk	+1 line, -1 line	2 comments	Download
	M	chrome/browser/resources/options2/inline_editable_list.js	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Tyler Breisacher (Chromium)

http://codereview.chromium.org/9665012/diff/1/chrome/browser/resources/options2/cookies_list.js File chrome/browser/resources/options2/cookies_list.js (left): http://codereview.chromium.org/9665012/diff/1/chrome/browser/resources/options2/cookies_list.js#oldcode537 chrome/browser/resources/options2/cookies_list.js:537: get parent(parent) { I assume the parameter is just ...

8 years, 9 months ago (2012-03-09 22:36:17 UTC) #1

arv (Not doing code reviews)

8 years, 9 months ago (2012-03-10 00:18:54 UTC) #4

FYI

http://codereview.chromium.org/9665012/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options2/cookies_list.js (left):

http://codereview.chromium.org/9665012/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options2/cookies_list.js:537: get parent(parent) {
On 2012/03/09 22:36:17, Tyler Breisacher wrote:
> I assume the parameter is just ignored, so I don't see how this could break
> anything.

This is a V8 bug. It is illegal to have paramaters in getters.

http://code.google.com/p/v8/issues/detail?id=1998

Expand Messages | Collapse Messages