Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1860)

Unified Diff: chrome/browser/resources/options2/cookies_list.js

Issue 9665012: Possible JavaScript errors caught by the closure compiler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options2/cookies_list.js
diff --git a/chrome/browser/resources/options2/cookies_list.js b/chrome/browser/resources/options2/cookies_list.js
index a0c215a574c565fcfbf8d148da6cf57a6ec9a62b..09f65bc884c51cb1ea7376db231d2bfa8749c373 100644
--- a/chrome/browser/resources/options2/cookies_list.js
+++ b/chrome/browser/resources/options2/cookies_list.js
@@ -534,7 +534,7 @@ cr.define('options', function() {
* The parent of this cookie tree node.
* @type {?CookieTreeNode|CookieListItem}
*/
- get parent(parent) {
Tyler Breisacher (Chromium) 2012/03/09 22:36:17 I assume the parameter is just ignored, so I don't
arv (Not doing code reviews) 2012/03/10 00:18:54 This is a V8 bug. It is illegal to have paramaters
+ get parent() {
// See below for an explanation of this special case.
if (typeof this.parent_ == 'number')
return this.list_.getListItemByIndex(this.parent_);

Powered by Google App Engine
This is Rietveld 408576698