Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9662021: Fixed pass-by-value to pass-by-reference (Closed)

Created:
8 years, 9 months ago by groby-ooo-7-16
Modified:
8 years, 9 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, darin-cc_chromium.org, Avi (use Gerrit), ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

[Coverity] Fixed pass-by-value to pass-by-reference TBR=asvitkine@chromium.org CID=103400 BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126258

Patch Set 1 #

Patch Set 2 : Fixed unit test compile errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -20 lines) Patch
M chrome/browser/tab_contents/thumbnail_generator.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/thumbnail_generator.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/tab_contents/thumbnail_generator_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/color_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/color_utils.cc View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
groby-ooo-7-16
jhawkins: Please review asvitkine: TBR'ed for ui/gfx changes
8 years, 9 months ago (2012-03-10 00:03:51 UTC) #1
James Hawkins
lgtm
8 years, 9 months ago (2012-03-10 00:08:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/9662021/1
8 years, 9 months ago (2012-03-10 00:20:25 UTC) #3
commit-bot: I haz the power
Try job failure for 9662021-1 (retry) on linux_rel for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-10 00:45:47 UTC) #4
groby-ooo-7-16
8 years, 9 months ago (2012-03-12 16:55:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/9662021/6002
8 years, 9 months ago (2012-03-12 20:21:51 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-12 22:57:38 UTC) #7 
Change committed as 126258

Powered by Google App Engine
This is Rietveld 408576698