Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: chrome/browser/tab_contents/thumbnail_generator.h

Issue 9662021: Fixed pass-by-value to pass-by-reference (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Fixed unit test compile errors Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/tab_contents/thumbnail_generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/thumbnail_generator.h
diff --git a/chrome/browser/tab_contents/thumbnail_generator.h b/chrome/browser/tab_contents/thumbnail_generator.h
index 5ef3bcc8b87e4c068dfbd2eb8398435d25718a00..bf905dd950fec9b4e0a06b8e81ce351b736d2336 100644
--- a/chrome/browser/tab_contents/thumbnail_generator.h
+++ b/chrome/browser/tab_contents/thumbnail_generator.h
@@ -109,7 +109,7 @@ class ThumbnailGenerator : public content::NotificationObserver,
// 0,1 ranged percentage of pixels that are the most common
// luma. Higher boring scores indicate that a higher percentage of a
// bitmap are all the same brightness.
- static double CalculateBoringScore(SkBitmap* bitmap);
+ static double CalculateBoringScore(const SkBitmap& bitmap);
// Gets the clipped bitmap from |bitmap| per the aspect ratio of the
// desired width and the desired height. For instance, if the input
@@ -125,8 +125,9 @@ class ThumbnailGenerator : public content::NotificationObserver,
void UpdateThumbnailIfNecessary(content::WebContents* webb_contents);
// Update the thumbnail of the given tab.
- void UpdateThumbnail(content::WebContents* web_contents, SkBitmap bitmap,
- const ThumbnailGenerator::ClipResult& clip_result);
+ void UpdateThumbnail(content::WebContents* web_contents,
+ const SkBitmap& bitmap,
+ const ThumbnailGenerator::ClipResult& clip_result);
// Returns true if we should update the thumbnail of the given URL.
static bool ShouldUpdateThumbnail(Profile* profile,
« no previous file with comments | « no previous file | chrome/browser/tab_contents/thumbnail_generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698