ui/gfx/color_utils.h - Issue 9662021: Fixed pass-by-value to pass-by-reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/color_utils.h

Issue 9662021: Fixed pass-by-value to pass-by-reference (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Fixed unit test compile errors Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/color_utils.h

diff --git a/ui/gfx/color_utils.h b/ui/gfx/color_utils.h

index 9b6bc14a9df1c3312af55dc4a2b403758cc425ff..c850eb046ed714fb09da3568d6772a515b6a0653 100644

--- a/ui/gfx/color_utils.h

+++ b/ui/gfx/color_utils.h

@@ -58,7 +58,7 @@ SkColor GetAverageColorOfFavicon(SkBitmap* bitmap, SkAlpha alpha);

// Builds a histogram based on the Y' of the Y'UV representation of

// this image.

-UI_EXPORT void BuildLumaHistogram(SkBitmap* bitmap, int histogram[256]);

+UI_EXPORT void BuildLumaHistogram(const SkBitmap& bitmap, int histogram[256]);

// Returns a blend of the supplied colors, ranging from |background| (for

// |alpha| == 0) to |foreground| (for |alpha| == 255). The alpha channels of

« no previous file with comments | « chrome/renderer/chrome_render_view_observer.cc ('k') | ui/gfx/color_utils.cc » ('j') | no next file with comments »