Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3019)

Unified Diff: base/base.gyp

Issue 9621014: Separate xvfb.py logic into its own script (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Save 5 lines, a variable is not needed Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | testing/test_env.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/base.gyp
diff --git a/base/base.gyp b/base/base.gyp
index 2d242bd30772006eaf6fa3621e36df126cd241ac..577e726e39a798b18cfff28604972c21b37b4c5c 100644
--- a/base/base.gyp
+++ b/base/base.gyp
@@ -449,12 +449,14 @@
],
'actions': [
{
- 'action_name': 'isolate',
+ 'action_name': 'response_file',
'inputs': [
'<(PRODUCT_DIR)/base_unittests<(EXECUTABLE_SUFFIX)',
+ '<(DEPTH)/testing/test_env.py',
+ '<(DEPTH)/testing/xvfb.py',
],
'conditions': [
- ['OS != "mac" and OS != "win"', {
+ ['OS=="linux"', {
'inputs': [
'<(PRODUCT_DIR)/xdisplaycheck<(EXECUTABLE_SUFFIX)',
],
@@ -467,6 +469,23 @@
}],
],
'outputs': [
+ '<(PRODUCT_DIR)/base_unittests.inputs',
+ ],
+ 'action': [
+ 'python',
+ '-c',
+ 'import sys; '
+ 'open(sys.argv[1], \'w\').write(\'\\n\'.join(sys.argv[2:]))',
+ '<@(_outputs)',
+ '<@(_inputs)',
+ ],
+ },
+ {
+ 'action_name': 'isolate',
+ 'inputs': [
+ '<(PRODUCT_DIR)/base_unittests.inputs',
+ ],
+ 'outputs': [
'<(PRODUCT_DIR)/base_unittests.results',
],
'action': [
@@ -475,13 +494,18 @@
'--mode=<(tests_run)',
'--root', '<(DEPTH)',
'--result', '<@(_outputs)',
- '<@(_inputs)',
+ '--files', '<@(_inputs)',
# Directories can't be tracked by build tools (make, msbuild, xcode,
# etc) so we just put it on the command line without specifying it
# as an input.
# TODO(maruel): Revisit the support for this at all and list each
# individual test files instead.
'data/file_util_unittest/',
+ '--',
+ # Wraps base_unittests under xvfb.
+ '<(DEPTH)/testing/xvfb.py',
+ '<(PRODUCT_DIR)',
+ '<(PRODUCT_DIR)/base_unittests<(EXECUTABLE_SUFFIX)',
],
},
],
« no previous file with comments | « no previous file | testing/test_env.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698