Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 9589003: Replace void* with int32 for passing download_id to SelectFileDialog::Listener. (Closed)

Created:
8 years, 9 months ago by achuithb
Modified:
8 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, rdsmith+dwatch_chromium.org
Visibility:
Public.

Description

Replace void* with int32 for passing download_id to SelectFileDialog::Listener. BUG=NONE TEST=trybot runs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124851

Patch Set 1 #

Patch Set 2 : update test mock #

Patch Set 3 : fix browser/unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -46 lines) Patch
M chrome/browser/download/chrome_download_manager_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_file_picker.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/download/download_file_picker.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M content/browser/download/download_manager_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/download/download_manager_impl.cc View 4 chunks +4 lines, -16 lines 0 comments Download
M content/browser/download/download_manager_impl_unittest.cc View 1 2 4 chunks +7 lines, -9 lines 0 comments Download
M content/public/browser/download_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/download_manager_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_download_manager_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_download_manager_delegate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/test/mock_download_manager.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
achuithb
Asanka for main review. Avi for content/public rubberstamp.
8 years, 9 months ago (2012-03-03 00:03:00 UTC) #1
achuithb
8 years, 9 months ago (2012-03-03 00:05:47 UTC) #2
zel
lgtm
8 years, 9 months ago (2012-03-03 00:36:43 UTC) #3
zel
you are missing fixes for unit tests, don't land before fixing those
8 years, 9 months ago (2012-03-03 00:37:24 UTC) #4
achuithb
On 2012/03/03 00:37:24, zel wrote: > you are missing fixes for unit tests, don't land ...
8 years, 9 months ago (2012-03-03 00:42:57 UTC) #5
Avi (use Gerrit)
happy owner is happy. lgtm fix all concerns of others before landing
8 years, 9 months ago (2012-03-03 02:38:58 UTC) #6
asanka
LGTM
8 years, 9 months ago (2012-03-03 05:19:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/9589003/7019
8 years, 9 months ago (2012-03-03 05:40:46 UTC) #8
commit-bot: I haz the power
Change committed as 124851
8 years, 9 months ago (2012-03-03 08:59:58 UTC) #9
achuithb
8 years, 9 months ago (2012-03-03 10:22:58 UTC) #10
Adding Randy for fyi.

Powered by Google App Engine
This is Rietveld 408576698