Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: content/shell/shell_download_manager_delegate.cc

Issue 9589003: Replace void* with int32 for passing download_id to SelectFileDialog::Listener. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix browser/unit tests Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/shell_download_manager_delegate.h ('k') | content/test/mock_download_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/shell_download_manager_delegate.cc
===================================================================
--- content/shell/shell_download_manager_delegate.cc (revision 124549)
+++ content/shell/shell_download_manager_delegate.cc (working copy)
@@ -104,7 +104,7 @@
void ShellDownloadManagerDelegate::ChooseDownloadPath(
WebContents* web_contents,
const FilePath& suggested_path,
- void* data) {
+ int32 download_id) {
FilePath result;
#if defined(OS_WIN)
std::wstring file_part = FilePath(suggested_path).BaseName().value();
@@ -132,9 +132,9 @@
#endif
if (result.empty()) {
- download_manager_->FileSelectionCanceled(data);
+ download_manager_->FileSelectionCanceled(download_id);
} else {
- download_manager_->FileSelected(result, data);
+ download_manager_->FileSelected(result, download_id);
}
}
« no previous file with comments | « content/shell/shell_download_manager_delegate.h ('k') | content/test/mock_download_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698