Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Side by Side Diff: chrome/browser/download/chrome_download_manager_delegate.h

Issue 9589003: Replace void* with int32 for passing download_id to SelectFileDialog::Listener. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix browser/unit tests Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/download/chrome_download_manager_delegate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_DOWNLOAD_CHROME_DOWNLOAD_MANAGER_DELEGATE_H_ 5 #ifndef CHROME_BROWSER_DOWNLOAD_CHROME_DOWNLOAD_MANAGER_DELEGATE_H_
6 #define CHROME_BROWSER_DOWNLOAD_CHROME_DOWNLOAD_MANAGER_DELEGATE_H_ 6 #define CHROME_BROWSER_DOWNLOAD_CHROME_DOWNLOAD_MANAGER_DELEGATE_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/hash_tables.h" 10 #include "base/hash_tables.h"
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 void SetDownloadManager(content::DownloadManager* dm); 49 void SetDownloadManager(content::DownloadManager* dm);
50 50
51 // Returns true if the given item is for an extension download. 51 // Returns true if the given item is for an extension download.
52 static bool IsExtensionDownload(const content::DownloadItem* item); 52 static bool IsExtensionDownload(const content::DownloadItem* item);
53 53
54 virtual void Shutdown() OVERRIDE; 54 virtual void Shutdown() OVERRIDE;
55 virtual content::DownloadId GetNextId() OVERRIDE; 55 virtual content::DownloadId GetNextId() OVERRIDE;
56 virtual bool ShouldStartDownload(int32 download_id) OVERRIDE; 56 virtual bool ShouldStartDownload(int32 download_id) OVERRIDE;
57 virtual void ChooseDownloadPath(content::WebContents* web_contents, 57 virtual void ChooseDownloadPath(content::WebContents* web_contents,
58 const FilePath& suggested_path, 58 const FilePath& suggested_path,
59 void* data) OVERRIDE; 59 int32 download_id) OVERRIDE;
60 virtual FilePath GetIntermediatePath(const FilePath& suggested_path) OVERRIDE; 60 virtual FilePath GetIntermediatePath(const FilePath& suggested_path) OVERRIDE;
61 virtual content::WebContents* 61 virtual content::WebContents*
62 GetAlternativeWebContentsToNotifyForDownload() OVERRIDE; 62 GetAlternativeWebContentsToNotifyForDownload() OVERRIDE;
63 virtual bool ShouldOpenFileBasedOnExtension(const FilePath& path) OVERRIDE; 63 virtual bool ShouldOpenFileBasedOnExtension(const FilePath& path) OVERRIDE;
64 virtual bool ShouldCompleteDownload(content::DownloadItem* item) OVERRIDE; 64 virtual bool ShouldCompleteDownload(content::DownloadItem* item) OVERRIDE;
65 virtual bool ShouldOpenDownload(content::DownloadItem* item) OVERRIDE; 65 virtual bool ShouldOpenDownload(content::DownloadItem* item) OVERRIDE;
66 virtual bool GenerateFileHash() OVERRIDE; 66 virtual bool GenerateFileHash() OVERRIDE;
67 virtual void AddItemToPersistentStore(content::DownloadItem* item) OVERRIDE; 67 virtual void AddItemToPersistentStore(content::DownloadItem* item) OVERRIDE;
68 virtual void UpdateItemInPersistentStore( 68 virtual void UpdateItemInPersistentStore(
69 content::DownloadItem* item) OVERRIDE; 69 content::DownloadItem* item) OVERRIDE;
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 // Maps from pending extension installations to DownloadItem IDs. 154 // Maps from pending extension installations to DownloadItem IDs.
155 typedef base::hash_map<CrxInstaller*, int> CrxInstallerMap; 155 typedef base::hash_map<CrxInstaller*, int> CrxInstallerMap;
156 CrxInstallerMap crx_installers_; 156 CrxInstallerMap crx_installers_;
157 157
158 content::NotificationRegistrar registrar_; 158 content::NotificationRegistrar registrar_;
159 159
160 DISALLOW_COPY_AND_ASSIGN(ChromeDownloadManagerDelegate); 160 DISALLOW_COPY_AND_ASSIGN(ChromeDownloadManagerDelegate);
161 }; 161 };
162 162
163 #endif // CHROME_BROWSER_DOWNLOAD_CHROME_DOWNLOAD_MANAGER_DELEGATE_H_ 163 #endif // CHROME_BROWSER_DOWNLOAD_CHROME_DOWNLOAD_MANAGER_DELEGATE_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/download/chrome_download_manager_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698