Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9570044: Rename chrome/browser/ui/views/{aura => ash}/ (Closed)

Created:
8 years, 9 months ago by Elliot Glaysher
Modified:
8 years, 9 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, ben+watch_chromium.org, aboxhall+watch_chromium.org, dhollowa+watch_chromium.org, yoshiki+watch_chromium.org, mihaip+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, Aaron Boodman, derat+watch_chromium.org, yusukes+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

Rename chrome/browser/ui/views/{aura => ash}/ BUG=116458 R=ben TBR=davemoore Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124752

Patch Set 1 #

Patch Set 2 : Also modify chrome_tests.gypi #

Patch Set 3 : Add rule about /ash/ directory to filename_rules.gypi #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -4765 lines) Patch
M build/filename_rules.gypi View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main_extra_parts_aura.cc View 1 2 3 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/status/accessibility_menu_button_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/status/caps_lock_menu_button_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/status/clock_menu_button_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/status/input_method_menu_button_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/status/power_menu_button_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/status/status_area_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system_key_event_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/ash/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/views/ash/app_list/app_list_model_builder.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/ash/app_list/app_list_model_builder.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/ash/app_list/app_list_model_builder_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/ash/app_list/app_list_view_delegate.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/ash/app_list/app_list_view_delegate.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/ash/app_list/browser_command_item.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/views/ash/app_list/browser_command_item.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/ash/app_list/chrome_app_list_item.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/ash/app_list/extension_app_item.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/views/ash/app_list/extension_app_item.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/ash/brightness_controller_chromeos.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/ash/brightness_controller_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/ash/caps_lock_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/ash/caps_lock_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/ash/caps_lock_handler_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/ash/chrome_shell_delegate.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/ash/chrome_shell_delegate.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/views/ash/ime_controller_chromeos.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/ash/ime_controller_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/ash/launcher/chrome_launcher_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/ash/launcher/chrome_launcher_delegate.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/views/ash/launcher/launcher_context_menu.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/ash/launcher/launcher_context_menu.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/views/ash/launcher/launcher_icon_loader.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/views/ash/launcher/launcher_icon_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/ash/launcher/launcher_updater.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/ash/launcher/launcher_updater.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/views/ash/launcher/launcher_updater_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/views/ash/multiple_window_indicator_button.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/ash/multiple_window_indicator_button.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/ash/panel_view_aura.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/ash/panel_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/ash/screen_orientation_listener.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/ash/screen_orientation_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/ash/screenshot_taker.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/ash/screenshot_taker.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/ash/status_area_host_aura.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/ash/status_area_host_aura.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/ash/status_area_host_aura_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/views/ash/volume_controller_chromeos.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/ash/volume_controller_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/views/aura/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/ui/views/aura/app_list/app_list_model_builder.h View 1 2 3 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/ui/views/aura/app_list/app_list_model_builder.cc View 1 2 3 1 chunk +0 lines, -113 lines 0 comments Download
D chrome/browser/ui/views/aura/app_list/app_list_model_builder_unittest.cc View 1 2 3 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/ui/views/aura/app_list/app_list_view_delegate.h View 1 2 3 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/browser/ui/views/aura/app_list/app_list_view_delegate.cc View 1 2 3 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/browser/ui/views/aura/app_list/browser_command_item.h View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/ui/views/aura/app_list/browser_command_item.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/ui/views/aura/app_list/chrome_app_list_item.h View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/ui/views/aura/app_list/extension_app_item.h View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/ui/views/aura/app_list/extension_app_item.cc View 1 2 3 1 chunk +0 lines, -181 lines 0 comments Download
D chrome/browser/ui/views/aura/brightness_controller_chromeos.h View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/ui/views/aura/brightness_controller_chromeos.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/ui/views/aura/caps_lock_handler.h View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/browser/ui/views/aura/caps_lock_handler.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/ui/views/aura/caps_lock_handler_browsertest.cc View 1 chunk +0 lines, -104 lines 0 comments Download
D chrome/browser/ui/views/aura/chrome_shell_delegate.h View 1 2 3 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/browser/ui/views/aura/chrome_shell_delegate.cc View 1 2 3 1 chunk +0 lines, -131 lines 0 comments Download
D chrome/browser/ui/views/aura/ime_controller_chromeos.h View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/ui/views/aura/ime_controller_chromeos.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/browser/ui/views/aura/launcher/chrome_launcher_delegate.h View 1 chunk +0 lines, -227 lines 0 comments Download
D chrome/browser/ui/views/aura/launcher/chrome_launcher_delegate.cc View 1 chunk +0 lines, -479 lines 0 comments Download
D chrome/browser/ui/views/aura/launcher/launcher_context_menu.h View 1 chunk +0 lines, -55 lines 0 comments Download
D chrome/browser/ui/views/aura/launcher/launcher_context_menu.cc View 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/browser/ui/views/aura/launcher/launcher_icon_loader.h View 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/browser/ui/views/aura/launcher/launcher_icon_loader.cc View 1 chunk +0 lines, -79 lines 0 comments Download
D chrome/browser/ui/views/aura/launcher/launcher_updater.h View 1 chunk +0 lines, -146 lines 0 comments Download
D chrome/browser/ui/views/aura/launcher/launcher_updater.cc View 1 chunk +0 lines, -332 lines 0 comments Download
D chrome/browser/ui/views/aura/launcher/launcher_updater_unittest.cc View 1 chunk +0 lines, -584 lines 0 comments Download
D chrome/browser/ui/views/aura/multiple_window_indicator_button.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/ui/views/aura/multiple_window_indicator_button.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/ui/views/aura/panel_view_aura.h View 1 chunk +0 lines, -105 lines 0 comments Download
D chrome/browser/ui/views/aura/panel_view_aura.cc View 1 chunk +0 lines, -411 lines 0 comments Download
D chrome/browser/ui/views/aura/screen_orientation_listener.h View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/ui/views/aura/screen_orientation_listener.cc View 1 chunk +0 lines, -92 lines 0 comments Download
D chrome/browser/ui/views/aura/screenshot_taker.h View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/ui/views/aura/screenshot_taker.cc View 1 chunk +0 lines, -94 lines 0 comments Download
D chrome/browser/ui/views/aura/status_area_host_aura.h View 1 chunk +0 lines, -95 lines 0 comments Download
D chrome/browser/ui/views/aura/status_area_host_aura.cc View 1 2 3 1 chunk +0 lines, -287 lines 0 comments Download
D chrome/browser/ui/views/aura/status_area_host_aura_browsertest.cc View 1 chunk +0 lines, -111 lines 0 comments Download
D chrome/browser/ui/views/aura/volume_controller_chromeos.h View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/ui/views/aura/volume_controller_chromeos.cc View 1 chunk +0 lines, -83 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 2 chunks +38 lines, -38 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Elliot Glaysher
All automatic with sed.
8 years, 9 months ago (2012-03-01 23:23:12 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 9 months ago (2012-03-01 23:29:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/9570044/9001
8 years, 9 months ago (2012-03-02 19:20:18 UTC) #3
commit-bot: I haz the power
Presubmit check for 9570044-9001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 9 months ago (2012-03-02 19:20:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/9570044/9001
8 years, 9 months ago (2012-03-02 20:07:52 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-02 22:40:59 UTC) #6 
Change committed as 124752

Powered by Google App Engine
This is Rietveld 408576698