Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9535025: Remove the singleton instance get/delete methods from RootWindow (yay) (Closed)

Created:
8 years, 9 months ago by Ben Goodger (Google)
Modified:
8 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Remove the singleton instance get/delete methods from RootWindow (yay) http://crbug.com/112131 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124635

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -142 lines) Patch
M ash/shell.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ash/shell.cc View 1 4 chunks +13 lines, -8 lines 0 comments Download
M ash/shell/shell_main.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/test/ash_test_base.cc View 1 3 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/chrome_browser_main_extra_parts_aura.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/notifications/desktop_notifications_unittest.cc View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/notifications/desktop_notifications_unittest.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/accessibility_event_router_views_unittest.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/base/chrome_render_view_host_test_harness.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/view_event_test_base.cc View 1 5 chunks +3 lines, -5 lines 0 comments Download
M content/browser/renderer_host/test_render_view_host.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/test_render_view_host.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M ui/aura/demo/demo_main.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/root_window.h View 1 2 chunks +2 lines, -5 lines 0 comments Download
M ui/aura/root_window.cc View 1 2 chunks +44 lines, -58 lines 0 comments Download
M ui/aura/root_window_host_linux.h View 1 2 chunks +1 line, -5 lines 0 comments Download
M ui/aura/root_window_host_linux.cc View 1 3 chunks +0 lines, -8 lines 0 comments Download
M ui/aura/test/aura_test_base.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/test/aura_test_base.cc View 1 1 chunk +9 lines, -10 lines 0 comments Download
M ui/views/test/views_test_base.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/test/views_test_base.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/widget/native_widget_aura_unittest.cc View 1 2 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ben Goodger (Google)
8 years, 9 months ago (2012-02-29 22:18:09 UTC) #1
sky
LGTM
8 years, 9 months ago (2012-02-29 22:32:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/9535025/23002
8 years, 9 months ago (2012-03-02 00:52:30 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-03-02 14:57:41 UTC) #4 
Change committed as 124635

Powered by Google App Engine
This is Rietveld 408576698