Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7505)

Unified Diff: chrome/test/base/view_event_test_base.cc

Issue 9535025: Remove the singleton instance get/delete methods from RootWindow (yay) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/ui_test_utils.cc ('k') | content/browser/renderer_host/test_render_view_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/view_event_test_base.cc
===================================================================
--- chrome/test/base/view_event_test_base.cc (revision 124527)
+++ chrome/test/base/view_event_test_base.cc (working copy)
@@ -68,7 +68,7 @@
void ViewEventTestBase::Done() {
MessageLoop::current()->Quit();
-#if defined(OS_WIN)
+#if defined(OS_WIN) && !defined(USE_AURA)
// We need to post a message to tickle the Dispatcher getting called and
// exiting out of the nested loop. Without this the quit never runs.
PostMessage(window_->GetNativeWindow(), WM_USER, 0, 0);
@@ -87,7 +87,6 @@
#endif
ui::CompositorTestSupport::Initialize();
#if defined(USE_AURA)
- ash::Shell::GetRootWindow();
ash::Shell::CreateInstance(NULL);
#endif
window_ = views::Widget::CreateWindow(this);
@@ -95,7 +94,7 @@
void ViewEventTestBase::TearDown() {
if (window_) {
-#if defined(OS_WIN)
+#if defined(OS_WIN) && !defined(USE_AURA)
DestroyWindow(window_->GetNativeWindow());
#else
window_->Close();
@@ -105,7 +104,6 @@
}
#if defined(USE_AURA)
ash::Shell::DeleteInstance();
- aura::RootWindow::DeleteInstance();
aura::Env::DeleteInstance();
#endif
ui::CompositorTestSupport::Terminate();
@@ -145,7 +143,7 @@
window_->Show();
// Make sure the window is the foreground window, otherwise none of the
// mouse events are going to be targeted correctly.
-#if defined(OS_WIN)
+#if defined(OS_WIN) && !defined(USE_AURA)
SetForegroundWindow(window_->GetNativeWindow());
#endif
« no previous file with comments | « chrome/test/base/ui_test_utils.cc ('k') | content/browser/renderer_host/test_render_view_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698