Remove the singleton instance get/delete methods from RootWindow (yay)

ui/aura/root_window.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/aura/root_window.h"
 
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 65 matching lines @@
 
 }  // namespace
 
 RootWindow* RootWindow::instance_ = NULL;
 bool RootWindow::use_fullscreen_host_window_ = false;
 bool RootWindow::hide_host_cursor_ = false;
 
 ////////////////////////////////////////////////////////////////////////////////
 // RootWindow, public:
 
-// static
-RootWindow* RootWindow::GetInstance() {
-  if (!instance_) {
-    instance_ = new RootWindow;
-    instance_->Init();
-  }
-  return instance_;
+RootWindow::RootWindow()
+    : Window(NULL),
+      host_(aura::RootWindowHost::Create(GetInitialHostWindowBounds())),
+      ALLOW_THIS_IN_INITIALIZER_LIST(schedule_paint_factory_(this)),
+      ALLOW_THIS_IN_INITIALIZER_LIST(event_factory_(this)),
+      mouse_button_flags_(0),
+      last_cursor_(kCursorNull),
+      cursor_shown_(true),
+      ALLOW_THIS_IN_INITIALIZER_LIST(screen_(new ScreenAura(this))),
+      capture_window_(NULL),
+      mouse_pressed_handler_(NULL),
+      mouse_moved_handler_(NULL),
+      focused_window_(NULL),
+      touch_event_handler_(NULL),
+      gesture_handler_(NULL),
+      ALLOW_THIS_IN_INITIALIZER_LIST(
+          gesture_recognizer_(GestureRecognizer::Create(this))),
+      synthesize_mouse_move_(false),
+      waiting_on_compositing_end_(false),
+      draw_on_compositing_end_(false) {
+  SetName("RootWindow");
+  gfx::Screen::SetInstance(screen_);
+  last_mouse_location_ = host_->QueryMouseLocation();
+
+  ui::Compositor::Initialize(false);
+  compositor_.reset(new ui::Compositor(this, host_->GetAcceleratedWidget(),
+      host_->GetSize()));
+  DCHECK(compositor_.get());
+  compositor_->AddObserver(this);
+  Init();
 }
 
-// static
-void RootWindow::DeleteInstance() {
-  delete instance_;
-  instance_ = NULL;
+RootWindow::~RootWindow() {
+  compositor_->RemoveObserver(this);
+  // Make sure to destroy the compositor before terminating so that state is
+  // cleared and we don't hit asserts.
+  compositor_.reset();
+
+  // Tear down in reverse.  Frees any references held by the host.
+  host_.reset(NULL);
+
+  // An observer may have been added by an animation on the RootWindow.
+  layer()->GetAnimator()->RemoveObserver(this);
+  ui::Compositor::Terminate();
+  if (instance_ == this)
+    instance_ = NULL;
 }
 
 void RootWindow::ShowRootWindow() {
   host_->Show();
 }
 
 void RootWindow::SetHostSize(const gfx::Size& size) {
   host_->SetSize(size);
   // Requery the location to constrain it within the new root window size.
   last_mouse_location_ = host_->QueryMouseLocation();
@@ skipping 337 matching lines @@
   waiting_on_compositing_end_ = false;
   if (draw_on_compositing_end_) {
     draw_on_compositing_end_ = false;
     Draw();
   }
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // RootWindow, private:
 
-RootWindow::RootWindow()
-    : Window(NULL),
-      host_(aura::RootWindowHost::Create(GetInitialHostWindowBounds())),
-      ALLOW_THIS_IN_INITIALIZER_LIST(schedule_paint_factory_(this)),
-      ALLOW_THIS_IN_INITIALIZER_LIST(event_factory_(this)),
-      mouse_button_flags_(0),
-      last_cursor_(kCursorNull),
-      cursor_shown_(true),
-      ALLOW_THIS_IN_INITIALIZER_LIST(screen_(new ScreenAura(this))),
-      capture_window_(NULL),
-      mouse_pressed_handler_(NULL),
-      mouse_moved_handler_(NULL),
-      focused_window_(NULL),
-      touch_event_handler_(NULL),
-      gesture_handler_(NULL),
-      ALLOW_THIS_IN_INITIALIZER_LIST(
-          gesture_recognizer_(GestureRecognizer::Create(this))),
-      synthesize_mouse_move_(false),
-      waiting_on_compositing_end_(false),
-      draw_on_compositing_end_(false) {
-  SetName("RootWindow");
-  gfx::Screen::SetInstance(screen_);
-  last_mouse_location_ = host_->QueryMouseLocation();
-
-  ui::Compositor::Initialize(false);
-  compositor_.reset(new ui::Compositor(this, host_->GetAcceleratedWidget(),
-      host_->GetSize()));
-  DCHECK(compositor_.get());
-  compositor_->AddObserver(this);
-}
-
-RootWindow::~RootWindow() {
-  compositor_->RemoveObserver(this);
-  // Make sure to destroy the compositor before terminating so that state is
-  // cleared and we don't hit asserts.
-  compositor_.reset();
-
-  // Tear down in reverse.  Frees any references held by the host.
-  host_.reset(NULL);
-
-  // An observer may have been added by an animation on the RootWindow.
-  layer()->GetAnimator()->RemoveObserver(this);
-  ui::Compositor::Terminate();
-  if (instance_ == this)
-    instance_ = NULL;
-}
-
 void RootWindow::HandleMouseCaptureChanged(Window* old_capture_window) {
   if (capture_window_)
     host_->SetCapture();
   else
     host_->ReleaseCapture();
 
   if (old_capture_window && old_capture_window->delegate()) {
     // Send a capture changed event with bogus location data.
     MouseEvent event(
         ui::ET_MOUSE_CAPTURE_CHANGED, gfx::Point(), gfx::Point(), 0);
@@ skipping 326 matching lines @@
   // is currently broken. See/ crbug.com/107931.
   MouseEvent event(ui::ET_MOUSE_MOVED,
                    orig_mouse_location,
                    orig_mouse_location,
                    ui::EF_IS_SYNTHESIZED);
   DispatchMouseEvent(&event);
 #endif
 }
 
 }  // namespace aura