Issue 9477016: Remove all |gfx::Image(new SkBitmap(...))| antipatterns.

Issue 9477016: Remove all |gfx::Image(new SkBitmap(...))| antipatterns. (Closed)

Created:
8 years, 10 months ago by Robert Sesek

Modified:
8 years, 9 months ago

Reviewers:
sail, Ben Goodger (Google)

CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Remove all |gfx::Image(new SkBitmap(...))| antipatterns. Now that gfx::Image can take a const-ref SkBitmap to copy it, the copy no longer needs to happen at the time of Image creation. The new constructor was added at http://codereview.chromium.org/9455062/. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126808

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -12 lines)			Patch
M	chrome/browser/favicon/favicon_handler.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/icon_loader_mac.mm	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/profiles/profile_info_util.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/themes/browser_theme_pack.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/extensions/extension_installed_bubble_bridge.mm	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 9 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/9477016/1

8 years, 9 months ago (2012-02-29 20:13:07 UTC) #4

commit-bot: I haz the power

Presubmit check for 9477016-1 failed and returned exit status 1. Running presubmit commit checks ...

8 years, 9 months ago (2012-02-29 20:13:11 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/9477016/1

8 years, 9 months ago (2012-03-14 21:32:24 UTC) #8

Change committed as 126808