chrome/browser/icon_loader_mac.mm - Issue 9477016: Remove all |gfx::Image(new SkBitmap(...))| antipatterns.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/icon_loader_mac.mm

Issue 9477016: Remove all |gfx::Image(new SkBitmap(...))| antipatterns. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/icon_loader_mac.mm

diff --git a/chrome/browser/icon_loader_mac.mm b/chrome/browser/icon_loader_mac.mm

index b90f796559579e117a52a91ca700c029642e60db..50555e41b6eac2eea71c17a96b5f289fc0d74f8a 100644

--- a/chrome/browser/icon_loader_mac.mm

+++ b/chrome/browser/icon_loader_mac.mm

@@ -33,8 +33,7 @@ void IconLoader::ReadIcon() {

default:

NOTREACHED();

}

- image_.reset(new gfx::Image(new SkBitmap(

- gfx::NSImageToSkBitmap(icon, size, false))));

+ image_.reset(new gfx::Image(gfx::NSImageToSkBitmap(icon, size, false)));

}

target_message_loop_->PostTask(FROM_HERE,