chrome/browser/icon_loader_mac.mm - Issue 9477016: Remove all |gfx::Image(new SkBitmap(...))| antipatterns.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/icon_loader_mac.mm

Issue 9477016: Remove all |gfx::Image(new SkBitmap(...))| antipatterns. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/icon_loader.h"	5 #include "chrome/browser/icon_loader.h"

6	6

7 #import <AppKit/AppKit.h>	7 #import <AppKit/AppKit.h>

8	8

9 #include "base/bind.h"	9 #include "base/bind.h"

10 #include "base/message_loop.h"	10 #include "base/message_loop.h"

(...skipping 15 matching lines...) Expand all Loading...
26 switch (icon_size_) {	26 switch (icon_size_) {

27 case IconLoader::SMALL:	27 case IconLoader::SMALL:

28 size = NSMakeSize(16, 16);	28 size = NSMakeSize(16, 16);

29 break;	29 break;

30 case IconLoader::NORMAL:	30 case IconLoader::NORMAL:

31 size = NSMakeSize(32, 32);	31 size = NSMakeSize(32, 32);

32 break;	32 break;

33 default:	33 default:

34 NOTREACHED();	34 NOTREACHED();

35 }	35 }

36 image_.reset(new gfx::Image(new SkBitmap(	36 image_.reset(new gfx::Image(gfx::NSImageToSkBitmap(icon, size, false)));

37 gfx::NSImageToSkBitmap(icon, size, false))));

38 }	37 }

39	38

40 target_message_loop_->PostTask(FROM_HERE,	39 target_message_loop_->PostTask(FROM_HERE,

41 base::Bind(&IconLoader::NotifyDelegate, this));	40 base::Bind(&IconLoader::NotifyDelegate, this));

42 }	41 }

OLD	NEW