Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9465030: Break two classes defined in json_value_serializer.cc, .h into separate files. (Closed)

Created:
8 years, 10 months ago by bbudge
Modified:
8 years, 10 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, kkania, amit, mihaip+watch_chromium.org, stevenjb+watch_chromium.org, dcaiafa+watch_chromium.org, ncarter (slow), jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, tim (not reviewing), wez+watch_chromium.org, Raghu Simha, sanjeevr, simonmorris+watch_chromium.org, sergeyu+watch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, akalin, garykac+watch_chromium.org, Aaron Boodman, lambroslambrou+watch_chromium.org, robertshield, jshin+watch_chromium.org, alexeypa+watch_chromium.org, James Su, davemoore+watch_chromium.org
Visibility:
Public.

Description

Break two classes defined in json_value_serializer.cc, .h into separate files. This will allow the use of JSONStringValueSerializer in the NaCl sandbox. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123701

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : Break two classes defined in json_value_serializer.cc, .h into separate files. #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -495 lines) Patch
M base/base.gypi View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
A + base/json/json_file_value_serializer.h View 1 2 3 4 3 chunks +5 lines, -65 lines 0 comments Download
A + base/json/json_file_value_serializer.cc View 1 2 3 4 1 chunk +4 lines, -42 lines 0 comments Download
A base/json/json_string_value_serializer.h View 1 2 3 4 1 chunk +78 lines, -0 lines 0 comments Download
A base/json/json_string_value_serializer.cc View 1 2 3 4 1 chunk +45 lines, -0 lines 0 comments Download
D base/json/json_value_serializer.h View 1 2 3 4 1 chunk +0 lines, -149 lines 0 comments Download
D base/json/json_value_serializer.cc View 1 2 3 4 1 chunk +0 lines, -134 lines 0 comments Download
M base/json/json_value_serializer_unittest.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/search_provider.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_codec_unittest.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_storage.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/cros/onc_network_parser.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/onc_network_parser_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/gdata_parser_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/proxy_config_service_impl.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/component_installers_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/component_unpacker.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/diagnostics/recon_diagnostics.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/webrequest/webrequest_api_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/component_loader.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/convert_user_script.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/convert_web_app.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_icon_manager_unittest.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_info_map_unittest.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_ui_unittest.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/external_pref_extension_loader.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/image_loading_tracker_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/permissions_updater_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/sandboxed_extension_unpacker.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/user_script_listener_unittest.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/intents/cws_intents_registry.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/intents/web_intents_registry_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/config_dir_policy_provider.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/config_dir_policy_provider_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/pref_model_associator.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/pref_service_uitest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_preference_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_profiler/task_profiler_data_serializer.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/themes/browser_theme_pack_unittest.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_unittest.mm View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/system_options_handler.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/quota_internals_ui.cc View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download
M chrome/common/extensions/extension_file_util.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_file_util_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_l10n_util.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_manifests_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_permission_set_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_unpacker.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/json_pref_store.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/json_schema_validator_unittest_base.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/json_value_serializer_perftest.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/json_value_serializer_unittest.cc View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/common/jstemplate_builder.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/web_apps_unittest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/google_chrome_distribution.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_chrome_distribution_unittest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/install_util.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/master_preferences.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/master_preferences_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/extension_helper.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/automation_json_requests.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/automation_proxy_uitest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/javascript_execution_controller.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/automation/tab_proxy.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/dom_checker_uitest.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/perf/dromaeo_benchmark_uitest.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/perf/sunspider_uitest.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/perf/v8_benchmark_uitest.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/ui/javascript_test_util.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/dom_automation_controller.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/policy_hack/nat_policy_linux.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
bbudge
sky for chrome/test wez for remoting brettw for everything else. Feel free to re-route if ...
8 years, 10 months ago (2012-02-25 00:40:15 UTC) #1
Wez
LGTM for remoting/
8 years, 10 months ago (2012-02-25 02:00:39 UTC) #2
bbudge
asargent for */extensions/
8 years, 10 months ago (2012-02-25 02:08:57 UTC) #3
brettw
8 years, 10 months ago (2012-02-25 18:22:42 UTC) #4 
LGTM. I don't think you need to get owners reviews for every directory just for
changing these include paths.

Powered by Google App Engine
This is Rietveld 408576698