Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: chrome/common/extensions/extension_manifests_unittest.cc

Issue 9465030: Break two classes defined in json_value_serializer.cc, .h into separate files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/extension.h" 5 #include "chrome/common/extensions/extension.h"
6 6
7 #if defined(TOOLKIT_GTK) 7 #if defined(TOOLKIT_GTK)
8 #include <gtk/gtk.h> 8 #include <gtk/gtk.h>
9 #endif 9 #endif
10 10
11 #include "base/command_line.h" 11 #include "base/command_line.h"
12 #include "base/file_path.h" 12 #include "base/file_path.h"
13 #include "base/file_util.h" 13 #include "base/file_util.h"
14 #include "base/i18n/rtl.h" 14 #include "base/i18n/rtl.h"
15 #include "base/json/json_value_serializer.h" 15 #include "base/json/json_file_value_serializer.h"
16 #include "base/memory/scoped_ptr.h" 16 #include "base/memory/scoped_ptr.h"
17 #include "base/path_service.h" 17 #include "base/path_service.h"
18 #include "base/string_number_conversions.h" 18 #include "base/string_number_conversions.h"
19 #include "base/string_util.h" 19 #include "base/string_util.h"
20 #include "base/stringprintf.h" 20 #include "base/stringprintf.h"
21 #include "base/utf_string_conversions.h" 21 #include "base/utf_string_conversions.h"
22 #include "chrome/common/chrome_paths.h" 22 #include "chrome/common/chrome_paths.h"
23 #include "chrome/common/chrome_switches.h" 23 #include "chrome/common/chrome_switches.h"
24 #include "chrome/common/extensions/extension.h" 24 #include "chrome/common/extensions/extension.h"
25 #include "chrome/common/extensions/extension_action.h" 25 #include "chrome/common/extensions/extension_action.h"
(...skipping 1010 matching lines...) Expand 10 before | Expand all | Expand 10 after
1036 EXPECT_EQ("", extension->page_action()->id()); 1036 EXPECT_EQ("", extension->page_action()->id());
1037 EXPECT_EQ(0u, extension->page_action()->icon_paths()->size()); 1037 EXPECT_EQ(0u, extension->page_action()->icon_paths()->size());
1038 EXPECT_EQ("", extension->page_action()->GetTitle( 1038 EXPECT_EQ("", extension->page_action()->GetTitle(
1039 ExtensionAction::kDefaultTabId)); 1039 ExtensionAction::kDefaultTabId));
1040 EXPECT_FALSE(extension->page_action()->HasPopup( 1040 EXPECT_FALSE(extension->page_action()->HasPopup(
1041 ExtensionAction::kDefaultTabId)); 1041 ExtensionAction::kDefaultTabId));
1042 1042
1043 LoadAndExpectError("page_action_manifest_version_2b.json", 1043 LoadAndExpectError("page_action_manifest_version_2b.json",
1044 errors::kInvalidPageActionPopup); 1044 errors::kInvalidPageActionPopup);
1045 } 1045 }
OLDNEW
« no previous file with comments | « chrome/common/extensions/extension_l10n_util.cc ('k') | chrome/common/extensions/extension_permission_set_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698