Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9456037: Adding run_at to chrome.tabs.executeScript/insertCss. (Closed)

Created:
8 years, 10 months ago by eaugusti
Modified:
8 years, 8 months ago
CC:
chromium-reviews, Aaron Boodman, darin-cc_chromium.org, mihaip+watch_chromium.org, brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Adding run_at to chrome.tabs.executeScript/insertCss. As per Aaron's suggestion I extended the functionality of UserScriptIdleScheduler to run different scripts at different times depending on when the script requested to be run. chrome.tabs.executeScript/insertCss now accept a 'runAt' parameter that follows the semantics specified here: http://code.google.com/chrome/extensions/content_scripts.html The script will be injected as earliest as the 'runAt' parameter. So I guess it is now more of a UserScriptScheduler. BUG=107286 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132230

Patch Set 1 #

Total comments: 32

Patch Set 2 : #

Total comments: 9

Patch Set 3 : #

Total comments: 12

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -321 lines) Patch
M chrome/browser/chromeos/accessibility/accessibility_util.cc View 1 2 3 5 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/execute_code_in_tab_function.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/execute_code_in_tab_function.cc View 1 2 4 chunks +19 lines, -1 line 0 comments Download
M chrome/browser/extensions/execute_script_apitest.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_module_constants.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_module_constants.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/tabs.json View 1 2 3 2 chunks +14 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/tabs.html View 1 2 3 2 chunks +56 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_messages.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/user_script.h View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/extension_helper.cc View 1 2 3 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/renderer/extensions/user_script_idle_scheduler.h View 1 1 chunk +0 lines, -78 lines 0 comments Download
D chrome/renderer/extensions/user_script_idle_scheduler.cc View 1 2 1 chunk +0 lines, -183 lines 0 comments Download
A + chrome/renderer/extensions/user_script_scheduler.h View 1 4 chunks +30 lines, -15 lines 0 comments Download
A + chrome/renderer/extensions/user_script_scheduler.cc View 1 2 3 5 chunks +62 lines, -33 lines 0 comments Download
A chrome/test/data/extensions/api_test/executescript/run_at/manifest.json View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/executescript/run_at/test.html View 1 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/executescript/run_at/test.js View 1 2 3 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Mihai Parparita -not on Chrome
As for how to test this, I suggest an API test where you have a ...
8 years, 9 months ago (2012-03-01 00:40:08 UTC) #1
Aaron Boodman
http://codereview.chromium.org/9456037/diff/1/chrome/browser/extensions/execute_code_in_tab_function.cc File chrome/browser/extensions/execute_code_in_tab_function.cc (right): http://codereview.chromium.org/9456037/diff/1/chrome/browser/extensions/execute_code_in_tab_function.cc#newcode25 chrome/browser/extensions/execute_code_in_tab_function.cc:25: #include "chrome/common/extensions/user_script.h" Since you include the header in the ...
8 years, 9 months ago (2012-03-03 00:59:10 UTC) #2
eaugusti
https://chromiumcodereview.appspot.com/9456037/diff/1/chrome/browser/extensions/execute_code_in_tab_function.cc File chrome/browser/extensions/execute_code_in_tab_function.cc (right): https://chromiumcodereview.appspot.com/9456037/diff/1/chrome/browser/extensions/execute_code_in_tab_function.cc#newcode25 chrome/browser/extensions/execute_code_in_tab_function.cc:25: #include "chrome/common/extensions/user_script.h" On 2012/03/03 00:59:10, Aaron Boodman wrote: > ...
8 years, 9 months ago (2012-03-27 00:43:33 UTC) #3
Aaron Boodman
https://chromiumcodereview.appspot.com/9456037/diff/9021/chrome/common/extensions/api/tabs.json File chrome/common/extensions/api/tabs.json (right): https://chromiumcodereview.appspot.com/9456037/diff/9021/chrome/common/extensions/api/tabs.json#newcode615 chrome/common/extensions/api/tabs.json:615: "descrption": "The soonest that the CSS will be injected ...
8 years, 9 months ago (2012-03-28 01:04:16 UTC) #4
eaugusti
https://chromiumcodereview.appspot.com/9456037/diff/9021/chrome/common/extensions/api/tabs.json File chrome/common/extensions/api/tabs.json (right): https://chromiumcodereview.appspot.com/9456037/diff/9021/chrome/common/extensions/api/tabs.json#newcode615 chrome/common/extensions/api/tabs.json:615: "descrption": "The soonest that the CSS will be injected ...
8 years, 8 months ago (2012-03-28 17:40:19 UTC) #5
Aaron Boodman
lgtm http://codereview.chromium.org/9456037/diff/9021/chrome/common/extensions/api/tabs.json File chrome/common/extensions/api/tabs.json (right): http://codereview.chromium.org/9456037/diff/9021/chrome/common/extensions/api/tabs.json#newcode615 chrome/common/extensions/api/tabs.json:615: "descrption": "The soonest that the CSS will be ...
8 years, 8 months ago (2012-03-30 21:47:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eaugusti@chromium.org/9456037/25002
8 years, 8 months ago (2012-03-30 21:51:31 UTC) #7
Mihai Parparita -not on Chrome
http://codereview.chromium.org/9456037/diff/25002/chrome/common/extensions/api/tabs.json File chrome/common/extensions/api/tabs.json (right): http://codereview.chromium.org/9456037/diff/25002/chrome/common/extensions/api/tabs.json#newcode583 chrome/common/extensions/api/tabs.json:583: "descrption": "The soonest that the script will be injected ...
8 years, 8 months ago (2012-03-30 23:29:55 UTC) #8
commit-bot: I haz the power
Try job failure for 9456037-25002 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 8 months ago (2012-03-31 00:15:20 UTC) #9
eaugusti
https://chromiumcodereview.appspot.com/9456037/diff/25002/chrome/common/extensions/api/tabs.json File chrome/common/extensions/api/tabs.json (right): https://chromiumcodereview.appspot.com/9456037/diff/25002/chrome/common/extensions/api/tabs.json#newcode583 chrome/common/extensions/api/tabs.json:583: "descrption": "The soonest that the script will be injected ...
8 years, 8 months ago (2012-04-10 02:26:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eaugusti@chromium.org/9456037/54001
8 years, 8 months ago (2012-04-13 17:30:54 UTC) #11
commit-bot: I haz the power
8 years, 8 months ago (2012-04-13 19:00:26 UTC) #12 
Change committed as 132230

Powered by Google App Engine
This is Rietveld 408576698