chrome/browser/extensions/extension_tabs_module.cc - Issue 9456037: Adding run_at to chrome.tabs.executeScript/insertCss.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_tabs_module.cc

Issue 9456037: Adding run_at to chrome.tabs.executeScript/insertCss. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_tabs_module.cc

diff --git a/chrome/browser/extensions/extension_tabs_module.cc b/chrome/browser/extensions/extension_tabs_module.cc

index ef450fdec583db4284b61d6b5b19149618a86ba9..e7bbd739775f322ecc9a4867e827332f01214225 100644

--- a/chrome/browser/extensions/extension_tabs_module.cc

+++ b/chrome/browser/extensions/extension_tabs_module.cc

@@ -48,6 +48,7 @@

#include "chrome/common/extensions/extension_manifest_constants.h"

#include "chrome/common/extensions/extension_error_utils.h"

#include "chrome/common/extensions/extension_messages.h"

+#include "chrome/common/extensions/user_script.h"

#include "chrome/common/pref_names.h"

#include "chrome/common/url_constants.h"

#include "content/public/browser/navigation_controller.h"

@@ -1313,6 +1314,7 @@ bool UpdateTabFunction::UpdateURLIfPresent(DictionaryValue* update_props,

params.extension_id = extension_id();

params.is_javascript = true;

params.code = url.path();

+ params.run_at = UserScript::DOCUMENT_IDLE;

params.all_frames = false;

params.in_main_world = true;