Adding run_at to chrome.tabs.executeScript/insertCss.

chrome/renderer/extensions/user_script_idle_scheduler.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_RENDERER_EXTENSIONS_USER_SCRIPT_IDLE_SCHEDULER_H_
 #define CHROME_RENDERER_EXTENSIONS_USER_SCRIPT_IDLE_SCHEDULER_H_
 #pragma once
 
 #include <queue>
 #include <vector>
@@ skipping 18 matching lines @@
 //
 // The intent of this mechanism is to prevent user scripts from slowing down
 // fast pages (run after load), while still allowing them to run relatively
 // timely for pages with lots of slow subresources.
 //
 // NOTE: this class does not inherit from RenderViewObserver on purpose.  The
 // reason is that this object is per frame, and a frame can move across
 // RenderViews thanks to adoptNode.  So we have each RenderView's
 // ExtensionHelper proxy these calls to the renderer process'
 // ExtensionDispatcher, which contains the mapping from WebFrame to us.
 class UserScriptIdleScheduler {

[Aaron Boodman, 2012/03/03 00:59:10]

Can you change the name of this class and rename the file to make it more
accurate? Usually rietveld is pretty good about detecting renames and not
marking the entire class new. If it fails, we can do it as a subsequent commit.

[eaugusti, 2012/03/27 00:43:34]

Done.

  public:
+  typedef

[Mihai Parparita -not on Chrome, 2012/03/01 00:40:08]

This typedef should be private.

[eaugusti, 2012/03/27 00:43:34]

Done.

+    std::vector<std::queue<linked_ptr<ExtensionMsg_ExecuteCode_Params> > >

[Mihai Parparita -not on Chrome, 2012/03/01 00:40:08]

Why not make this a map from RunLocation to the queue of code to execute? 

[eaugusti, 2012/03/27 00:43:34]

Done.

+    Schedule;
+
   UserScriptIdleScheduler(WebKit::WebFrame* frame,
                           ExtensionDispatcher* extension_dispatcher);
   ~UserScriptIdleScheduler();
 
   void ExecuteCode(const ExtensionMsg_ExecuteCode_Params& params);
+  void DidCreateDocumentElement();
   void DidFinishDocumentLoad();
   void DidFinishLoad();
   void DidStartProvisionalLoad();
 
  private:
   // Run user scripts, except if they've already run for this frame, or the
   // frame has been destroyed.
   void MaybeRun();
 
   // Backend for the IPC Message ExecuteCode in addition to being used
   // internally.
   void ExecuteCodeImpl(const ExtensionMsg_ExecuteCode_Params& params);
 
   // Get all child frames of parent_frame, returned by frames_vector.
   bool GetAllChildFrames(WebKit::WebFrame* parent_frame,
                          std::vector<WebKit::WebFrame*>* frames_vector) const;
 
+  // Call to signify thet the idle timeout has expired.
+  void IdleTimeout();
+
   base::WeakPtrFactory<UserScriptIdleScheduler> weak_factory_;
 
   // The Frame we will run scripts in.
   WebKit::WebFrame* frame_;
 
   // Whether we have already run scripts.
   bool has_run_;
 
+  // The current location in the document lodaing process.

[Mihai Parparita -not on Chrome, 2012/03/01 00:40:08]

Typo ("lodaing").

[eaugusti, 2012/03/27 00:43:34]

Done.

+  // Will be -1 if it is before any scripts should be run.
+  // Otherwise it will be one of UserScript::RunLocation
+  int current_location_;
+
   // This is only used if we're for the main frame.
-  std::queue<linked_ptr<ExtensionMsg_ExecuteCode_Params> >
-      pending_code_execution_queue_;
+  Schedule pending_code_execution_queue_;
 
   ExtensionDispatcher* extension_dispatcher_;
 };
 
 #endif  // CHROME_RENDERER_EXTENSIONS_USER_SCRIPT_IDLE_SCHEDULER_H_