Use SequencedWorkerPool for disk operations in TraceSubscriberStdio.

Use SequencedWorkerPool for disk operations in TraceSubscriberStdio.

This class was hitting a ThreadRestrictions assert because it called
OpenFile on the UI thread. To reduce unnecessary copying, I've changed
the OnTraceDataCollected argument from std::string to RefCountedString.

Second attempt (originally committed in 123140, reverted in 123146).
Added DISALLOW_COPY_AND_ASSIGN to fix Windows compilation error.

BUG=None
TEST=content_unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123433

[Iain Merrick, 2012-02-23 17:59:16]

This is a repeat of http://codereview.chromium.org/9333003/, which got reverted
due to a build error on win_aura.

The only change here is that I've added DISALLOW_COPY_AND_ASSIGN to
TraceSubscriberStdio, which includes a RefPtr<TraceSubscriberStdioImpl>. VC++
must have been trying to instantiate the copy constructor, and failing because
it's a forward declaration.

[willchan no longer on Chromium, 2012-02-23 18:04:38]

LGTM

Btw, in the future, you can help reviewers by, before making any changes to the
revert, just uploading the revert, and then making the change. That way we can
see the change to the original revert in the "delta from patch set". Cheers!

On 2012/02/23 17:59:16, Iain Merrick wrote:
> This is a repeat of http://codereview.chromium.org/9333003/, which got
reverted
> due to a build error on win_aura.
> 
> The only change here is that I've added DISALLOW_COPY_AND_ASSIGN to
> TraceSubscriberStdio, which includes a RefPtr<TraceSubscriberStdioImpl>. VC++
> must have been trying to instantiate the copy constructor, and failing because
> it's a forward declaration.

[Iain Merrick, 2012-02-23 18:07:20]

Aha, I was wondering. I figured I should upload it to the original issue but git
cl wouldn't cooperate. Thanks for the tip!

[jam, 2012-02-23 19:24:18]

lgtm

[James Hawkins, 2012-02-23 21:06:02]

LGTM

[commit-bot: I haz the power, 2012-02-23 21:49:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/husky@chromium.org/9443020/1

[commit-bot: I haz the power, 2012-02-24 01:06:54]

Try job failure for 9443020-1 (retry) on win_rel for step "ui_tests".
It's a second try, previously, steps "browser_tests, ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-02-24 01:38:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/husky@chromium.org/9443020/1

[commit-bot: I haz the power, 2012-02-24 04:17:09]

Change committed as 123433