Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5219)

Unified Diff: chrome/browser/ui/webui/tracing_ui.cc

Issue 9443020: Use SequencedWorkerPool for disk operations in TraceSubscriberStdio. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/automation/automation_provider.cc ('k') | chrome/test/base/tracing.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/tracing_ui.cc
diff --git a/chrome/browser/ui/webui/tracing_ui.cc b/chrome/browser/ui/webui/tracing_ui.cc
index 3a1c492af7e7e69876f514706afcf733d779c634..9f5bc5fe1b76f33c8b297fde651eb217c39a6887 100644
--- a/chrome/browser/ui/webui/tracing_ui.cc
+++ b/chrome/browser/ui/webui/tracing_ui.cc
@@ -73,7 +73,8 @@ class TracingMessageHandler
// TraceSubscriber implementation.
virtual void OnEndTracingComplete();
- virtual void OnTraceDataCollected(const std::string& trace_fragment);
+ virtual void OnTraceDataCollected(
+ const scoped_refptr<base::RefCountedString>& trace_fragment);
virtual void OnTraceBufferPercentFullReply(float percent_full);
// GpuDataManagerObserver implementation.
@@ -379,7 +380,7 @@ void TracingMessageHandler::OnEndTracingComplete() {
}
void TracingMessageHandler::OnTraceDataCollected(
- const std::string& trace_fragment) {
+ const scoped_refptr<base::RefCountedString>& trace_fragment) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
base::debug::TraceResultBuffer::SimpleOutput output;
@@ -387,7 +388,7 @@ void TracingMessageHandler::OnTraceDataCollected(
trace_buffer.SetOutputCallback(output.GetCallback());
output.Append("tracingController.onTraceDataCollected(");
trace_buffer.Start();
- trace_buffer.AddFragment(trace_fragment);
+ trace_buffer.AddFragment(trace_fragment->data());
trace_buffer.Finish();
output.Append(");");
« no previous file with comments | « chrome/browser/automation/automation_provider.cc ('k') | chrome/test/base/tracing.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698