Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: content/browser/trace_subscriber_stdio.h

Issue 9443020: Use SequencedWorkerPool for disk operations in TraceSubscriberStdio. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/trace_message_filter.cc ('k') | content/browser/trace_subscriber_stdio.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/trace_subscriber_stdio.h
diff --git a/content/browser/trace_subscriber_stdio.h b/content/browser/trace_subscriber_stdio.h
index b9742e2d5a37f14dbbc8381571b13fbdfecbd3de..f252f0b745f6f8054dc3e66afe22b4a212a32075 100644
--- a/content/browser/trace_subscriber_stdio.h
+++ b/content/browser/trace_subscriber_stdio.h
@@ -12,32 +12,27 @@
#include "content/browser/trace_controller.h"
#include "content/common/content_export.h"
+namespace content {
+
+class TraceSubscriberStdioImpl;
+
// Stdio implementation of TraceSubscriber. Use this to write traces to a file.
class CONTENT_EXPORT TraceSubscriberStdio : public TraceSubscriber {
public:
- TraceSubscriberStdio();
// Creates or overwrites the specified file. Check IsValid() for success.
explicit TraceSubscriberStdio(const FilePath& path);
-
- // Creates or overwrites the specified file. Returns true on success.
- bool OpenFile(const FilePath& path);
- // Finishes json output and closes file.
- void CloseFile();
-
- // Returns TRUE if we're currently writing data to a file.
- bool IsValid();
+ virtual ~TraceSubscriberStdio();
// Implementation of TraceSubscriber
virtual void OnEndTracingComplete() OVERRIDE;
- virtual void OnTraceDataCollected(const std::string& trace_fragment) OVERRIDE;
-
- virtual ~TraceSubscriberStdio();
+ virtual void OnTraceDataCollected(
+ const scoped_refptr<base::RefCountedString>& data_ptr) OVERRIDE;
private:
- void Write(const std::string& output_str);
-
- FILE* file_;
- base::debug::TraceResultBuffer trace_buffer_;
+ scoped_refptr<TraceSubscriberStdioImpl> impl_;
+ DISALLOW_COPY_AND_ASSIGN(TraceSubscriberStdio);
};
+} // namespace content
+
#endif // CONTENT_BROWSER_TRACE_SUBSCRIBER_STDIO_H_
« no previous file with comments | « content/browser/trace_message_filter.cc ('k') | content/browser/trace_subscriber_stdio.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698