PPAPI: Add unlocking for PPP calls and callbacks. Add more locking.

PPAPI: Add unlocking for PPP calls and callbacks. Add more locking.

With this patch, ppapi_tests pass locally when building with enable_pepper_threading=1. (They didn't before).

TODO: Test more calls off the main thread, make sync completion callbacks work.

BUG=92909
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121901

[dmichael (off chromium), 2012-02-13 20:37:47]

This is largely mechanical (except proxy_lock.h/.cc). Everything is still behind
a gyp flag. I still need to add tests of calls off the main thread and flush out
problems. We also need to get completion callbacks working (a) from the invoking
thread and (b) in the blocking case.

[brettw, 2012-02-13 20:52:34]

http://codereview.chromium.org/9391006/diff/5001/ppapi/proxy/ppb_message_loop...
File ppapi/proxy/ppb_message_loop_proxy.cc (right):

http://codereview.chromium.org/9391006/diff/5001/ppapi/proxy/ppb_message_loop...
ppapi/proxy/ppb_message_loop_proxy.cc:201: RunWhileLocked(closure),
Isn't this closure into user code, where we would want to be unlocked?

http://codereview.chromium.org/9391006/diff/5001/ppapi/proxy/ppp_instance_pri...
File ppapi/proxy/ppp_instance_private_proxy_unittest.cc (right):

http://codereview.chromium.org/9391006/diff/5001/ppapi/proxy/ppp_instance_pri...
ppapi/proxy/ppp_instance_private_proxy_unittest.cc:62:
//PpapiGlobals::Get()->GetVarTracker()->AddRefVar(instance_obj);
Delete this line?

[dmichael (off chromium), 2012-02-13 21:15:32]

http://codereview.chromium.org/9391006/diff/5001/ppapi/proxy/ppb_message_loop...
File ppapi/proxy/ppb_message_loop_proxy.cc (right):

http://codereview.chromium.org/9391006/diff/5001/ppapi/proxy/ppb_message_loop...
ppapi/proxy/ppb_message_loop_proxy.cc:201: RunWhileLocked(closure),
On 2012/02/13 20:52:34, brettw wrote:
> Isn't this closure into user code, where we would want to be unlocked?
Yes, thank you, nice catch. I added a comment to PostClosure that it doesn't
acquire the lock, to hopefully prevent somebody using it to schedule proxy
operations. Currently PostQuit uses it too, but that doesn't need to grab the
lock either.

http://codereview.chromium.org/9391006/diff/5001/ppapi/proxy/ppp_instance_pri...
File ppapi/proxy/ppp_instance_private_proxy_unittest.cc (right):

http://codereview.chromium.org/9391006/diff/5001/ppapi/proxy/ppp_instance_pri...
ppapi/proxy/ppp_instance_private_proxy_unittest.cc:62:
//PpapiGlobals::Get()->GetVarTracker()->AddRefVar(instance_obj);
On 2012/02/13 20:52:34, brettw wrote:
> Delete this line?

Done.

[brettw, 2012-02-13 21:19:37]

lgtm

[commit-bot: I haz the power, 2012-02-13 21:39:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/9391006/8001

[commit-bot: I haz the power, 2012-02-13 22:23:24]

Try job failure for 9391006-8001 (retry) on linux_clang for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2012-02-14 16:31:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/9391006/11001

[commit-bot: I haz the power, 2012-02-14 18:05:41]

Change committed as 121901