PPAPI: Add unlocking for PPP calls and callbacks. Add more locking.

ppapi/proxy/ppb_message_loop_proxy.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/proxy/ppb_message_loop_proxy.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
@@ skipping 179 matching lines @@
     return false;  // Can't be current if there's nothing in the slot.
   return static_cast<const void*>(globals->msg_loop_slot()->Get()) ==
          static_cast<const void*>(this);
 }
 
 void MessageLoopResource::PostClosure(
     const tracked_objects::Location& from_here,
     const base::Closure& closure,
     int64 delay_ms) {
   if (loop_.get()) {
-    loop_->PostDelayedTask(
-        from_here, closure, base::TimeDelta::FromMilliseconds(delay_ms));
+    loop_->PostDelayedTask(from_here,
+                           RunWhileLocked(closure),

[brettw, 2012/02/13 20:52:34]

Isn't this closure into user code, where we would want to be unlocked?

[dmichael (off chromium), 2012/02/13 21:15:33]

Yes, thank you, nice catch. I added a comment to PostClosure that it doesn't
acquire the lock, to hopefully prevent somebody using it to schedule proxy
operations. Currently PostQuit uses it too, but that doesn't need to grab the
lock either.

+                           base::TimeDelta::FromMilliseconds(delay_ms));
   } else {
     TaskInfo info;
     info.from_here = FROM_HERE;
     info.closure = closure;
     info.delay_ms = delay_ms;
     pending_tasks_.push_back(info);
   }
 }
 
 // static
@@ skipping 74 matching lines @@
 PPB_MessageLoop_Proxy::~PPB_MessageLoop_Proxy() {
 }
 
 // static
 const PPB_MessageLoop_Dev_0_1* PPB_MessageLoop_Proxy::GetInterface() {
   return &ppb_message_loop_interface;
 }
 
 }  // namespace proxy
 }  // namespace ppapi