PPAPI: Add unlocking for PPP calls and callbacks. Add more locking.

ppapi/proxy/ppp_instance_private_proxy_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/message_loop.h"
 #include "base/test/test_timeouts.h"
 #include "base/time.h"
 #include "ppapi/c/dev/ppb_var_deprecated.h"
 #include "ppapi/c/dev/ppp_class_deprecated.h"
@@ skipping 40 matching lines @@
       plugin_dispatcher->GetBrowserInterface(
           PPB_VAR_DEPRECATED_INTERFACE));
 }
 
 // Mock PPP_Instance_Private.
 PP_Var instance_obj;
 PP_Var GetInstanceObject(PP_Instance /*instance*/) {
   // The 1 ref we got from CreateObject will be passed to the host. We want to
   // have a ref of our own.
   printf("GetInstanceObject called\n");
-  PpapiGlobals::Get()->GetVarTracker()->AddRefVar(instance_obj);
+  plugin_var_deprecated_if()->AddRef(instance_obj);
+  //PpapiGlobals::Get()->GetVarTracker()->AddRefVar(instance_obj);

[brettw, 2012/02/13 20:52:34]

Delete this line?

[dmichael (off chromium), 2012/02/13 21:15:33]

Done.

   return instance_obj;
 }
 
 PPP_Instance_Private ppp_instance_private_mock = {
   &GetInstanceObject
 };
 
 // We need to mock PPP_Instance, so that we can create and destroy the pretend
 // instance that PPP_Instance_Private uses.
 PP_Bool DidCreate(PP_Instance /*instance*/, uint32_t /*argc*/,
@@ skipping 103 matching lines @@
   // Destroy the instance. DidDestroy above decrements the reference count for
   // instance_obj, so it should also be destroyed.
   ppp_instance->DidDestroy(kInstance);
   EXPECT_EQ(-1, plugin().var_tracker().GetRefCountForObject(instance_obj));
   EXPECT_EQ(-1, host().var_tracker().GetRefCountForObject(host_pp_var));
 }
 
 }  // namespace proxy
 }  // namespace ppapi