content/browser/download/download_item_impl.h - Issue 9351024: Clean up unused members and constructors from DownloadCreateInfo and DownloadSaveInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_item_impl.h

Issue 9351024: Clean up unused members and constructors from DownloadCreateInfo and DownloadSaveInfo (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: " Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/download/download_create_info.cc ('k') | content/browser/download/download_item_impl.cc » ('j') | content/browser/download/download_types.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/download_item_impl.h

diff --git a/content/browser/download/download_item_impl.h b/content/browser/download/download_item_impl.h

index c3d31194af18f77940b72b1a2d80afaaca7890d5..44d19c03fe95637ec6b017a51f01d23ba68a123f 100644

--- a/content/browser/download/download_item_impl.h

+++ b/content/browser/download/download_item_impl.h

@@ -245,17 +245,14 @@ class CONTENT_EXPORT DownloadItemImpl : public content::DownloadItem {

// Full path to the downloaded or downloading file.

FilePath full_path_;

- // A number that should be appended to the path to make it unique, or 0 if the

- // path should be used as is.

- int path_uniquifier_;

// The chain of redirects that leading up to and including the final URL.

std::vector<GURL> url_chain_;

// The URL of the page that initiated the download.

GURL referrer_url_;

- // Suggested filename in 'download' attribute of an anchor. Details:

+ // Filename suggestion from DownloadSaveInfo. It could, among others, be the

+ // suggested filename in 'download' attribute of an anchor. Details:

Randy Smith (Not in Mondays) 2012/02/08 18:53:54 Just for my curiosity--are you familiar with the c

asanka 2012/02/08 19:02:43 This is in RenderMessageFilter::OnDownloadUrl() (c

// http://www.whatwg.org/specs/web-apps/current-work/#downloading-hyperlinks

std::string suggested_filename_;

@@ -360,8 +357,7 @@ class CONTENT_EXPORT DownloadItemImpl : public content::DownloadItem {

// be treated as though the user opened it.

bool opened_;

- // Do we actual open downloads when requested? For testing purposes

- // only.

+ // Do we actually open downloads when requested? For testing purposes only.

bool open_enabled_;

// Did the delegate delay calling Complete on this download?