Clean up unused members and constructors from DownloadCreateInfo and DownloadSaveInfo

content/browser/download/download_item_impl.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_IMPL_H_
 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_IMPL_H_
 #pragma once
 
 #include <string>
 
@@ skipping 227 matching lines @@
   // The handle to the request information.  Used for operations outside the
   // download system.
   scoped_ptr<DownloadRequestHandleInterface> request_handle_;
 
   // Download ID assigned by DownloadResourceHandler.
   content::DownloadId download_id_;
 
   // Full path to the downloaded or downloading file.
   FilePath full_path_;
 
-  // A number that should be appended to the path to make it unique, or 0 if the
-  // path should be used as is.
-  int path_uniquifier_;
-
   // The chain of redirects that leading up to and including the final URL.
   std::vector<GURL> url_chain_;
 
   // The URL of the page that initiated the download.
   GURL referrer_url_;
 
-  // Suggested filename in 'download' attribute of an anchor. Details:
+  // Filename suggestion from DownloadSaveInfo. It could, among others, be the
+  // suggested filename in 'download' attribute of an anchor. Details:

[Randy Smith (Not in Mondays), 2012/02/08 18:53:54]

Just for my curiosity--are you familiar with the code they mention?  (I.e. does
it actually exist?)  The only use I'm aware of for suggested_filename_ is from
the programmatic download pathways.

[asanka, 2012/02/08 19:02:43]

This is in RenderMessageFilter::OnDownloadUrl()
(content/browser/renderer_host/render_message_filter.cc).

   // http://www.whatwg.org/specs/web-apps/current-work/#downloading-hyperlinks
   std::string suggested_filename_;
 
   // Information from the request.
   // Content-disposition field from the header.
   std::string content_disposition_;
 
   // Mime-type from the header.  Subject to change.
   std::string mime_type_;
 
@@ skipping 84 matching lines @@
 
   // True if we've saved all the data for the download.
   bool all_data_saved_;
 
   // Did the user open the item either directly or indirectly (such as by
   // setting always open files of this type)? The shelf also sets this field
   // when the user closes the shelf before the item has been opened but should
   // be treated as though the user opened it.
   bool opened_;
 
-  // Do we actual open downloads when requested?  For testing purposes
-  // only.
+  // Do we actually open downloads when requested?  For testing purposes only.
   bool open_enabled_;
 
   // Did the delegate delay calling Complete on this download?
   bool delegate_delayed_complete_;
 
   // External Data storage.  All objects in the store
   // are owned by the DownloadItemImpl.
   std::map<const void*, ExternalData*> external_data_map_;
 
   DISALLOW_COPY_AND_ASSIGN(DownloadItemImpl);
 };
 
 #endif  // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_IMPL_H_