Clean up unused members and constructors from DownloadCreateInfo and DownloadSaveInfo

Clean up unused members and constructors from DownloadCreateInfo and DownloadSaveInfo

BUG=78085
TEST=unit tests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121251

[Randy Smith (Not in Mondays), 2012-02-08 18:53:54]

LGTM.  (I'm tempted to put a caveat on this, as I didn't dig in and confirm that
these were *really* unused, but that caveat would be "As long as it compiles"
which seems like a safe assumption :-}.)

http://codereview.chromium.org/9351024/diff/4001/content/browser/download/dow...
File content/browser/download/download_item_impl.h (right):

http://codereview.chromium.org/9351024/diff/4001/content/browser/download/dow...
content/browser/download/download_item_impl.h:255: // suggested filename in
'download' attribute of an anchor. Details:
Just for my curiosity--are you familiar with the code they mention?  (I.e. does
it actually exist?)  The only use I'm aware of for suggested_filename_ is from
the programmatic download pathways.

http://codereview.chromium.org/9351024/diff/4001/content/browser/download/dow...
File content/browser/download/download_types.h (right):

http://codereview.chromium.org/9351024/diff/4001/content/browser/download/dow...
content/browser/download/download_types.h:28: // a path (only a filename), and
is only effective if |file_path| is empty.
Thank you for improving these comments.

[asanka, 2012-02-08 19:02:43]

http://codereview.chromium.org/9351024/diff/4001/content/browser/download/dow...
File content/browser/download/download_item_impl.h (right):

http://codereview.chromium.org/9351024/diff/4001/content/browser/download/dow...
content/browser/download/download_item_impl.h:255: // suggested filename in
'download' attribute of an anchor. Details:
On 2012/02/08 18:53:54, rdsmith wrote:
> Just for my curiosity--are you familiar with the code they mention?  (I.e.
does
> it actually exist?)  The only use I'm aware of for suggested_filename_ is from
> the programmatic download pathways.

This is in RenderMessageFilter::OnDownloadUrl()
(content/browser/renderer_host/render_message_filter.cc).

[commit-bot: I haz the power, 2012-02-09 14:24:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asanka@chromium.org/9351024/6002

[commit-bot: I haz the power, 2012-02-09 14:24:11]

Can't apply patch for file content/browser/download/download_create_info.cc.
While running patch -p1 --forward --force;
patching file content/browser/download/download_create_info.cc
Hunk #1 FAILED at 11.
Hunk #2 succeeded at 53 (offset 2 lines).
1 out of 2 hunks FAILED -- saving rejects to file
content/browser/download/download_create_info.cc.rej

[commit-bot: I haz the power, 2012-02-09 16:39:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asanka@chromium.org/9351024/15001

[commit-bot: I haz the power, 2012-02-09 18:18:28]

Change committed as 121251