Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 9342007: Add HTTP PUT request type to content:URLFetcher (Closed)

Created:
8 years, 10 months ago by kuan
Modified:
8 years, 10 months ago
Reviewers:
jam, wtc
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam
Visibility:
Public.

Description

content::URLFetcher: Add HTTP PUT request type and method to append header string. PUT request is needed for uploading files to gdata. BUG=chromium-os:25357 TEST=nothing yet. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120731

Patch Set 1 #

Total comments: 8

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
MM content/common/net/url_fetcher_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/common/net/url_fetcher_impl.cc View 1 2 chunks +6 lines, -1 line 0 comments Download
M content/public/common/url_fetcher.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M content/test/test_url_fetcher_factory.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/test/test_url_fetcher_factory.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
kuan
8 years, 10 months ago (2012-02-06 22:31:33 UTC) #1
wtc
Review comments on Patch Set 1: Thank you for the patch. I suggest some changes ...
8 years, 10 months ago (2012-02-06 23:34:07 UTC) #2
kuan
i've addressed all ur comments. ptal, thanks. http://codereview.chromium.org/9342007/diff/1/content/common/net/url_fetcher_impl.cc File content/common/net/url_fetcher_impl.cc (right): http://codereview.chromium.org/9342007/diff/1/content/common/net/url_fetcher_impl.cc#newcode821 content/common/net/url_fetcher_impl.cc:821: case PUT: ...
8 years, 10 months ago (2012-02-06 23:58:16 UTC) #3
wtc
Patch Set 2 LGTM. Are you working with satorux on this feature?
8 years, 10 months ago (2012-02-07 01:25:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kuan@chromium.org/9342007/6001
8 years, 10 months ago (2012-02-07 02:14:51 UTC) #5
commit-bot: I haz the power
Presubmit check for 9342007-6001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 10 months ago (2012-02-07 02:14:55 UTC) #6
kuan
jam, could u provide owner's approval for added method in url_fetcher.h? thanks.
8 years, 10 months ago (2012-02-07 02:18:24 UTC) #7
jam
lgtm for public
8 years, 10 months ago (2012-02-07 02:46:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kuan@chromium.org/9342007/6001
8 years, 10 months ago (2012-02-07 02:53:54 UTC) #9
commit-bot: I haz the power
8 years, 10 months ago (2012-02-07 06:56:29 UTC) #10
Change committed as 120731

Powered by Google App Engine
This is Rietveld 408576698