Add HTTP PUT request type to content:URLFetcher

content/common/net/url_fetcher_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/net/url_fetcher_impl.h"
 
 #include <set>
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
@@ skipping 800 matching lines @@
       break;
 
     case HEAD:
       request_->set_method("HEAD");
       break;
 
     case DELETE_REQUEST:
       request_->set_method("DELETE");
       break;
 
+    case PUT:

[wtc, 2012/02/06 23:34:07]

Let's list the PUT case right below the POST case because
the two cases are very similar.

I wonder if it's possible to merge the code for the two
cases.

[kuan, 2012/02/06 23:58:17]

Done.

+      DCHECK(!upload_content_.empty());

[wtc, 2012/02/06 23:34:07]

I studied the Section 9.6 PUT in the HTTP 1.1 RFC 2616.
I don't see anything that forbids the use of chunked
encoding.  So I think this DCHECK should look like the
DCHECK on line 801 for the POST case.

[kuan, 2012/02/06 23:58:17]

Done.  Since chunked encoding is also allowed for PUT, i've merged both POST and
PUT together.

+      DCHECK(!upload_content_type_.empty());
+
+      request_->set_method("PUT");
+      extra_request_headers_.SetHeader(net::HttpRequestHeaders::kContentType,
+                                       upload_content_type_);
+      request_->AppendBytesToUpload(
+          upload_content_.data(), static_cast<int>(upload_content_.length()));
+      break;
+
     default:
       NOTREACHED();
   }
 
   if (!extra_request_headers_.IsEmpty())
     request_->SetExtraRequestHeaders(extra_request_headers_);
 
   // There might be data left over from a previous request attempt.
   data_.clear();
 
@@ skipping 137 matching lines @@
 int URLFetcherImpl::GetLoadFlags() const {
   return core_->load_flags_;
 }
 
 void URLFetcherImpl::SetExtraRequestHeaders(
     const std::string& extra_request_headers) {
   core_->extra_request_headers_.Clear();
   core_->extra_request_headers_.AddHeadersFromString(extra_request_headers);
 }
 
+void URLFetcherImpl::AddRequestHeaderFromString(
+    const base::StringPiece& header_line) {
+  core_->extra_request_headers_.AddHeaderFromString(header_line);
+}
+
 void URLFetcherImpl::GetExtraRequestHeaders(net::HttpRequestHeaders* headers) {
   headers->CopyFrom(core_->extra_request_headers_);
 }
 
 void URLFetcherImpl::SetRequestContext(
     net::URLRequestContextGetter* request_context_getter) {
   DCHECK(!core_->request_context_getter_);
   core_->request_context_getter_ = request_context_getter;
 }
 
@@ skipping 138 matching lines @@
 
 // static
 content::URLFetcherFactory* URLFetcherImpl::factory() {
   return g_factory;
 }
 
 // static
 void URLFetcherImpl::set_factory(content::URLFetcherFactory* factory) {
   g_factory = factory;
 }