Add HTTP PUT request type to content:URLFetcher

content/public/common/url_fetcher.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_COMMON_URL_FETCHER_H_
 #define CONTENT_PUBLIC_COMMON_URL_FETCHER_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 58 matching lines @@
   enum ResponseCode {
     RESPONSE_CODE_INVALID = -1
   };
 
   enum RequestType {
     GET,
     POST,
     HEAD,
     DELETE_REQUEST,   // DELETE is already taken on Windows.
                       // <winnt.h> defines a DELETE macro.
+    PUT,
   };
 
   // |url| is the URL to send the request to.
   // |request_type| is the type of request to make.
   // |d| the object that will receive the callback on fetch completion.
   static URLFetcher* Create(const GURL& url,
                             RequestType request_type,
                             URLFetcherDelegate* d);
 
   // Like above, but if there's a URLFetcherFactory registered with the
@@ skipping 46 matching lines @@
 
   // The referrer URL for the request. Must be called before the request is
   // started.
   virtual void SetReferrer(const std::string& referrer) = 0;
 
   // Set extra headers on the request.  Must be called before the request
   // is started.
   virtual void SetExtraRequestHeaders(
       const std::string& extra_request_headers) = 0;
 
+  // Add header (with format $key ":" $value) to the request headers.

[wtc, 2012/02/06 23:34:07]

Nit: I'd omit the dollar signs ($) in the format description.

You can consider using the exact wording from HTTP 1.1:

    field-name ":" [ field-value ]

[kuan, 2012/02/06 23:58:17]

Done.

+  // Must be called before the request is started.
+  virtual void AddRequestHeaderFromString(
+      const base::StringPiece& header_line) = 0;

[wtc, 2012/02/06 23:34:07]

It's important to explain the difference between this
method and the SetExtraRequestHeaders method above.
One important difference (ignoring the std::string vs.
base::StringPiece difference) is that SetExtraRequestHeaders
replaces the extra request headers whereas this method
appends one header.

I suggest renaming this method AddExtraRequestHeader.

I also suggest using the same data type (either std::string
or base::StringPiece) for both methods.

[kuan, 2012/02/06 23:58:17]

Done.

+
   virtual void GetExtraRequestHeaders(net::HttpRequestHeaders* headers) = 0;
 
   // Set the net::URLRequestContext on the request.  Must be called before the
   // request is started.
   virtual void SetRequestContext(
       net::URLRequestContextGetter* request_context_getter) = 0;
 
   // If |retry| is false, 5xx responses will be propagated to the observer,
   // if it is true URLFetcher will automatically re-execute the request,
   // after backoff_delay() elapses. URLFetcher has it set to true by default.
@@ skipping 68 matching lines @@
   // true, caller takes responsibility for the temp file, and it will not
   // be removed once the URLFetcher is destroyed.  User should not take
   // ownership more than once, or call this method after taking ownership.
   virtual bool GetResponseAsFilePath(bool take_ownership,
                                      FilePath* out_response_path) const = 0;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_COMMON_URL_FETCHER_H_