Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 9307009: Remove CHECKs used for bug investigation. (Closed)

Created:
8 years, 10 months ago by xhwang
Modified:
8 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Removed CHECKs used for bug investigation. CHECKs was added when investigating issue 103957 and issue 95732. Since these two bugs have been fixed, remove CHECKs or replace with normal error handling. BUG=95732, 103957 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120763

Patch Set 1 #

Total comments: 1

Patch Set 2 : Keep DCHECK to prevent regression. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -23 lines) Patch
M content/browser/renderer_host/render_message_filter.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/common/gpu/gpu_channel_manager.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/ppapi_plugin/ppapi_thread.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M content/renderer/pepper_plugin_delegate_impl.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
xhwang
Hi ddorwin, Removed some CHECKs as issue 103957 and issue 95732 are fixed. Could you ...
8 years, 10 months ago (2012-02-01 02:18:45 UTC) #1
ddorwin
LGTM. You'll need OWNERs approval and it would be good to have a GPU person ...
8 years, 10 months ago (2012-02-01 02:25:23 UTC) #2
xhwang
Hello, jam, apatrick and piman, Could you please do an ONWERS review. jam: content/browser/renderer_host/render_message_filter.cc apatrick: ...
8 years, 10 months ago (2012-02-02 00:42:41 UTC) #3
jam
lgtm for my part
8 years, 10 months ago (2012-02-02 21:48:11 UTC) #4
piman
LGTM. Please consider leaving DCHECKs to help catching regressions if the root cause of those ...
8 years, 10 months ago (2012-02-03 18:52:22 UTC) #5
apatrick_chromium
Sorry missed this. LGTM
8 years, 10 months ago (2012-02-06 18:24:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/9307009/7001
8 years, 10 months ago (2012-02-06 21:02:28 UTC) #7
commit-bot: I haz the power
Try job failure for 9307009-7001 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 10 months ago (2012-02-06 23:06:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/9307009/7001
8 years, 10 months ago (2012-02-07 00:38:58 UTC) #9
commit-bot: I haz the power
8 years, 10 months ago (2012-02-07 11:05:59 UTC) #10
Change committed as 120763

Powered by Google App Engine
This is Rietveld 408576698