Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11352)

Unified Diff: content/renderer/render_thread_impl.cc

Issue 9307009: Remove CHECKs used for bug investigation. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Keep DCHECK to prevent regression. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/pepper_plugin_delegate_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_thread_impl.cc
diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc
index 0cb8d20375ad2a994e7fcad449496d84ec4bd819..2be13809d4e821cc69de210cc16b93ce93b49c11 100644
--- a/content/renderer/render_thread_impl.cc
+++ b/content/renderer/render_thread_impl.cc
@@ -797,18 +797,15 @@ GpuChannelHost* RenderThreadImpl::EstablishGpuChannelSync(
&renderer_process_for_gpu,
&gpu_info)) ||
channel_handle.name.empty() ||
+#if defined(OS_POSIX)
+ channel_handle.socket.fd == -1 ||
+#endif
renderer_process_for_gpu == base::kNullProcessHandle) {
// Otherwise cancel the connection.
gpu_channel_ = NULL;
return NULL;
}
-#if defined(OS_POSIX)
- // Check the validity of fd for bug investigation. Replace with normal error
- // handling (see above) after bug fixed. See for details: crbug.com/95732.
- CHECK_NE(-1, channel_handle.socket.fd);
-#endif
-
gpu_channel_->set_gpu_info(gpu_info);
content::GetContentClient()->SetGpuInfo(gpu_info);
« no previous file with comments | « content/renderer/pepper_plugin_delegate_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698