content/renderer/pepper_plugin_delegate_impl.cc - Issue 9307009: Remove CHECKs used for bug investigation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper_plugin_delegate_impl.cc

Issue 9307009: Remove CHECKs used for bug investigation. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Keep DCHECK to prevent regression. Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/pepper_plugin_delegate_impl.cc

diff --git a/content/renderer/pepper_plugin_delegate_impl.cc b/content/renderer/pepper_plugin_delegate_impl.cc

index b736ef5dbf6fe8d18226f784706503fda330414b..d03b7acb437282085c6d67e8b9e442fb627ac282 100644

--- a/content/renderer/pepper_plugin_delegate_impl.cc

+++ b/content/renderer/pepper_plugin_delegate_impl.cc

@@ -530,9 +530,7 @@ class HostDispatcherWrapper

return false;

#if defined(OS_POSIX)

- // Check the validity of fd for bug investigation. Remove after fixed.

- // See for details: crbug.com/103957.

- CHECK_NE(-1, channel_handle.socket.fd);

+ DCHECK_NE(-1, channel_handle.socket.fd);

if (channel_handle.socket.fd == -1)

return false;

#endif

@@ -682,6 +680,7 @@ bool BrokerDispatcherWrapper::Init(

return false;

#if defined(OS_POSIX)

+ DCHECK_NE(-1, channel_handle.socket.fd);

if (channel_handle.socket.fd == -1)

return false;

#endif

« no previous file with comments | « content/ppapi_plugin/ppapi_thread.cc ('k') | content/renderer/render_thread_impl.cc » ('j') | no next file with comments »