Issue 9298039: ninja: Support --toplevel-dir.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9298039: ninja: Support --toplevel-dir. (Closed)

Created:
8 years, 11 months ago by Nico

Modified:
8 years, 11 months ago

Reviewers:
Evan Martin

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

ninja: Support --toplevel-dir. Committed: https://code.google.com/p/gyp/source/detail?r=1185

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	pylib/gyp/generator/ninja.py	View		1 chunk	+1 line, -3 lines	0 comments	Download
	M	test/toplevel-dir/gyptest-toplevel-dir.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

LGTM huh, so what does it mean? the dir where out/Foo is relative to?

8 years, 11 months ago (2012-01-28 02:58:42 UTC) #2

Nico

8 years, 11 months ago (2012-01-28 03:03:41 UTC) #3

On 2012/01/28 02:58:42, Evan Martin wrote:
> LGTM
> 
> huh, so what does it mean?  the dir where out/Foo is relative to?

The dir where out/ goes.

In a standalone webkit checkout, gyp_webkit is in

  Source/WebKit/chromium/gyp_webkit

That script calls gyp with --toplevel-dir=../../.. and --depth=.

Before this change, base_dir would be e.g. ../../WebCore/WebCore.gyp (because
the path was relative to ., which is Source/WebKit/chromium, and the gyp file
was in Source/WebCore/WebCore.gyp/WebCore.gyp). InvertRelativePath() would then
throw, because '..' is in that path.

After this change, base_dir is WebCore/WebCore.gyp, since it's now relative to
the root of the webkit checkout.

http://codereview.chromium.org/2122004 is the CL that added this to the make
build.

Expand Messages | Collapse Messages