Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pylib/gyp/generator/ninja.py

Issue 9298039: ninja: Support --toplevel-dir. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/toplevel-dir/gyptest-toplevel-dir.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/generator/ninja.py
===================================================================
--- pylib/gyp/generator/ninja.py (revision 1184)
+++ pylib/gyp/generator/ninja.py (working copy)
@@ -1127,9 +1127,7 @@
if flavor == 'mac':
gyp.xcode_emulation.MergeGlobalXcodeSettingsToSpec(data[build_file], spec)
- # TODO: what is options.depth and how is it different than
- # options.toplevel_dir?
- build_file = gyp.common.RelativePath(build_file, options.depth)
+ build_file = gyp.common.RelativePath(build_file, options.toplevel_dir)
base_path = os.path.dirname(build_file)
obj = 'obj'
« no previous file with comments | « no previous file | test/toplevel-dir/gyptest-toplevel-dir.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698