Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 9297027: (On behalf of yusukes) Handle Caps Lock short cut (Shift+Search) in ash [part 2 of 2]. (Closed)

Created:
8 years, 11 months ago by dmazzoni
Modified:
8 years, 11 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, derat+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

(On behalf of yusukes) Handle Caps Lock short cut (Shift+Search) in ash [part 2 of 2]. Add caps_lock_handler.cc which implements ash::CapsLockDelegate. Part 1 of 2: http://codereview.chromium.org/9242003 Original review for Part 2 of 2: http://codereview.chromium.org/9225004/ (LGTM'ed by ben@chromium.org and derat@chromium.org) BUG=110129 TEST=ran browser_tests TBR=ben@chromium.org,derat@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119513

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -1 line) Patch
M chrome/browser/chrome_browser_main_extra_parts_aura.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/system_key_event_listener.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/system_key_event_listener_browsertest.cc View 1 chunk +6 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/aura/caps_lock_handler.h View 1 chunk +62 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/aura/caps_lock_handler.cc View 1 chunk +59 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/aura/caps_lock_handler_browsertest.cc View 1 chunk +104 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/aura/screenshot_taker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Emmanuel Saint-loubert-Bié
8 years, 11 months ago (2012-01-27 21:45:26 UTC) #1
lgtm

Powered by Google App Engine
This is Rietveld 408576698