Handle Caps Lock short cut (Shift+Search) in ash [part 1 of 2].

Handle Caps Lock short cut (Shift+Search) in ash [part 1 of 2].

Currently it's handled in chrome/browser/chromeos/system_key_event_listener.cc by checking the X event loop directly, but for Aura, it'd be better to remove the X dependency by moving the code to ash/accelerators/ since any class except aura::RootWindowHost should not handle an X event directly.

Part 2 of 2: https://chromiumcodereview.appspot.com/9225004/

BUG=110129
TEST=ran aura_shell_unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118035

[mazda, 2012-01-17 07:34:05]

https://chromiumcodereview.appspot.com/9242003/diff/1/ash/accelerators/accele...
File ash/accelerators/accelerator_controller.cc (right):

https://chromiumcodereview.appspot.com/9242003/diff/1/ash/accelerators/accele...
ash/accelerators/accelerator_controller.cc:51: // On Chrome OS, Search key is
mapped to LWIN.
Is it OK that this is handled on Windows as well?

https://chromiumcodereview.appspot.com/9242003/diff/1/ash/accelerators/accele...
File ash/accelerators/accelerator_controller.h (right):

https://chromiumcodereview.appspot.com/9242003/diff/1/ash/accelerators/accele...
ash/accelerators/accelerator_controller.h:60: scoped_ptr<ScreenshotDelegate>
screenshot_delegate);
I prefer this signature change is done first in another CL.
That would make this CL more organized.

[Yusuke Sato, 2012-01-17 08:24:52]

please take another look.

https://chromiumcodereview.appspot.com/9242003/diff/1/ash/accelerators/accele...
File ash/accelerators/accelerator_controller.cc (right):

https://chromiumcodereview.appspot.com/9242003/diff/1/ash/accelerators/accele...
ash/accelerators/accelerator_controller.cc:51: // On Chrome OS, Search key is
mapped to LWIN.
On 2012/01/17 07:34:05, mazda wrote:
> Is it OK that this is handled on Windows as well?

I might be wrong, but my guess is that Ash on Windows should toggle Caps Lock
when Shift+VKEY_LWIN is pressed since it's basically a Chrome OS emulator.

https://chromiumcodereview.appspot.com/9242003/diff/1/ash/accelerators/accele...
File ash/accelerators/accelerator_controller.h (right):

https://chromiumcodereview.appspot.com/9242003/diff/1/ash/accelerators/accele...
ash/accelerators/accelerator_controller.h:60: scoped_ptr<ScreenshotDelegate>
screenshot_delegate);
On 2012/01/17 07:34:05, mazda wrote:
> I prefer this signature change is done first in another CL.
> That would make this CL more organized.

Done. Please review https://chromiumcodereview.appspot.com/9240002/

[mazda, 2012-01-17 08:31:36]

lgtm

>I might be wrong, but my guess is that Ash on Windows should toggle Caps Lock
> when Shift+VKEY_LWIN is pressed since it's basically a Chrome OS emulator.
I see.
Thank you for the explanation.

[Yusuke Sato, 2012-01-17 08:36:11]

+ben
Could you review this?

[Ben Goodger (Google), 2012-01-17 16:31:02]

lgtm

[commit-bot: I haz the power, 2012-01-17 22:51:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusukes@chromium.org/9242003/4001

[commit-bot: I haz the power, 2012-01-18 04:12:16]

Change committed as 118035