net: Don't merge HTTP headers and body if the body is not in memory.

net/http/http_stream_parser.h

Index: net/http/http_stream_parser.h
diff --git a/net/http/http_stream_parser.h b/net/http/http_stream_parser.h
index 34ec522ba1b2a3dcc8996b0953ee327d42050edc..b87beab733300dc51af56238cc2a845d17353b6f 100644
--- a/net/http/http_stream_parser.h
+++ b/net/http/http_stream_parser.h
@@ -91,6 +91,11 @@ class NET_EXPORT_PRIVATE HttpStreamParser  : public ChunkCallback {
                          char* output,
                          size_t output_size);
 
+  // Returns true if request and body should be merged (i.e. the sum is

[wtc, 2012/01/24 19:08:04]

Note: 'request' consists of 'request headers' and 'request body',
so this comment needs to be more verbose to be accurate:
  Returns true if request headers and body should be merged...

+  // small enough and the body is in memory, and not chunked).
+  static bool ShouldMerge(const std::string& request,

[wtc, 2012/01/24 19:08:04]

The 'request' parameter should be renamed 'request_headers'.

Nit: this method name should say what should be merged.
For example, ShouldMergeRequestBody or the more verbose
ShouldMergeRequestHeadersAndBody.

[satorux1, 2012/01/24 19:25:42]

I like the idea and chose the latter.

+                          const UploadDataStream* request_body);
+
   // The number of extra bytes required to encode a chunk.
   static const size_t kChunkHeaderFooterSize;