Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2884)

Unified Diff: net/base/upload_data_unittest.cc

Issue 9270030: net: Don't merge HTTP headers and body if the body is not in memory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix win build Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/upload_data_unittest.cc
diff --git a/net/base/upload_data_unittest.cc b/net/base/upload_data_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..5d56523ff41bbbb1f9432b53a70adb5a7fa9bf5b
--- /dev/null
+++ b/net/base/upload_data_unittest.cc
@@ -0,0 +1,61 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/base/upload_data.h"
+
+#include "base/file_path.h"
+#include "base/memory/ref_counted.h"
+#include "base/time.h"
+#include "googleurl/src/gurl.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace net {
+
+TEST(UploadDataTest, IsInMemory_Empty) {
+ scoped_refptr<UploadData> upload_data = new UploadData;
+ ASSERT_TRUE(upload_data->IsInMemory());
+}
+
+TEST(UploadDataTest, IsInMemory_Bytes) {
+ scoped_refptr<UploadData> upload_data = new UploadData;
+ upload_data->AppendBytes("123", 3);
+ ASSERT_TRUE(upload_data->IsInMemory());
+}
+
+TEST(UploadDataTest, IsInMemory_File) {
+ scoped_refptr<UploadData> upload_data = new UploadData;
+ upload_data->AppendFileRange(
+ FilePath(FILE_PATH_LITERAL("random_file_name.txt")),
+ 0, 0, base::Time());
+ ASSERT_FALSE(upload_data->IsInMemory());
+}
+
+TEST(UploadDataTest, IsInMemory_Blob) {
+ scoped_refptr<UploadData> upload_data = new UploadData;
+ upload_data->AppendBlob(GURL("blog:internal:12345"));
+ // Until it's resolved, we don't know what blob contains.
+ ASSERT_FALSE(upload_data->IsInMemory());
+}
+
+TEST(UploadDataTest, IsInMemory_Chunk) {
+ scoped_refptr<UploadData> upload_data = new UploadData;
+ upload_data->set_is_chunked(true);
+ ASSERT_FALSE(upload_data->IsInMemory());
+}
+
+TEST(UploadDataTest, IsInMemory_Mixed) {
+ scoped_refptr<UploadData> upload_data = new UploadData;
+ ASSERT_TRUE(upload_data->IsInMemory());
+
+ upload_data->AppendBytes("123", 3);
+ upload_data->AppendBytes("abc", 3);
+ ASSERT_TRUE(upload_data->IsInMemory());
+
+ upload_data->AppendFileRange(
+ FilePath(FILE_PATH_LITERAL("random_file_name.txt")),
+ 0, 0, base::Time());
+ ASSERT_FALSE(upload_data->IsInMemory());
+}
+
+} // namespace net

Powered by Google App Engine
This is Rietveld 408576698